Skip to content

LibWeb: Relax HTML parser to allow more tags inside <select>#6899

Merged
AtkinsSJ merged 1 commit intoLadybirdBrowser:masterfrom
F3n67u:relax-html-parser-customizable-select
Dec 4, 2025
Merged

LibWeb: Relax HTML parser to allow more tags inside <select>#6899
AtkinsSJ merged 1 commit intoLadybirdBrowser:masterfrom
F3n67u:relax-html-parser-customizable-select

Conversation

@F3n67u
Copy link
Copy Markdown
Contributor

@F3n67u F3n67u commented Nov 21, 2025

This implements parsing part of customizable spec update. See whatwg/html#10548.

@F3n67u F3n67u force-pushed the relax-html-parser-customizable-select branch 3 times, most recently from 3d10f52 to 31d1a2f Compare November 22, 2025 19:39
@F3n67u F3n67u force-pushed the relax-html-parser-customizable-select branch from 31d1a2f to 7f64bc2 Compare November 24, 2025 17:54
@F3n67u F3n67u requested a review from gmta November 25, 2025 16:42
@F3n67u
Copy link
Copy Markdown
Contributor Author

F3n67u commented Dec 4, 2025

@gmta I resolved your comments. Could you please take a look when you get a chance? Thank you!

Copy link
Copy Markdown
Member

@AtkinsSJ AtkinsSJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me.

Comment thread Libraries/LibWeb/HTML/Parser/HTMLParser.cpp Outdated
This implements parsing part of customizable <select> spec update.
See whatwg/html PR #10548.

Two failing subtests in `html5lib_innerHTML_tests_innerHTML_1.html`
and `customizable-select/select-parsing.html` are due to the spec
still disallowing `<input>` inside `<select>`, even though Chrome
has already implemented this behavoir (see whatwg/html#11288).
@AtkinsSJ AtkinsSJ enabled auto-merge (rebase) December 4, 2025 17:06
@AtkinsSJ AtkinsSJ merged commit d2029b1 into LadybirdBrowser:master Dec 4, 2025
10 checks passed
@F3n67u F3n67u deleted the relax-html-parser-customizable-select branch December 4, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants