logger: write warnings to stderr, not stdout#197
Open
selimdev00 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
logger.warnwrites to stdout viaconsole.log:Warnings are diagnostics, not results, so they belong on stderr. Emitting them on stdout corrupts any machine-readable stdout - e.g. a
--jsonpayload or a value being piped/captured - by interleaving a yellow warning line into it. Several real warnings flow through here: corruptbmalph/config.json, corruptbmalph/state/current-phase.json, malformed_bmad/config.yaml, and the platform-resolution fallback. A consumer parsing stdout JSON can hit a syntax error purely because the project state was slightly off.Fix
info/debugare unchanged. Thequietgate is unchanged. This is purely a stream correctness fix.Tests
warnnow asserts on stderr and additionally asserts nothing is written to stdout.console.logspy (config, state, platform resolve) to spy onconsole.error- which also documents that those warnings were previously landing on stdout.