modules/noctalia: init#169
Open
Kruemmelspalter wants to merge 1 commit into
Open
Conversation
e7e921e to
6f52ec3
Compare
Collaborator
|
ah the failure is to be expected given that its not yet in nixpkgs ig. guess i need to update the flake lock once its merged |
Collaborator
|
otherwise looks like any of the simple modules so far, so nothing to nitpick from my side |
6f52ec3 to
692f68d
Compare
Author
|
as of NixOS/nixpkgs#530804, the noctalia package will probably not be upstreamed into nixpkgs until v5 is actually released |
64012ce to
158933a
Compare
1b79fb2 to
d606392
Compare
Author
|
the package now has to be supplied when calling the module like wrapperModules.noctalia.apply {
inherit pkgs;
package = <package>;
settings = <...>;
} |
Collaborator
you still need to remove the check then because there is no package to actually drive it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waiting for