feat: add appearance data layer and theme wiring (accent, font, size)#64
Open
LeGeRyChEeSe wants to merge 1 commit into
Open
feat: add appearance data layer and theme wiring (accent, font, size)#64LeGeRyChEeSe wants to merge 1 commit into
LeGeRyChEeSe wants to merge 1 commit into
Conversation
First slice of the appearance-customization feature (docs/sonnet5-specs/02). Lays the data + theme groundwork; no settings screen yet, so behavior is unchanged (defaults reproduce the original hardcoded look exactly). - AppearanceModels.kt: AppearanceSettings + enums (ThemeMode, AppFont, BackgroundStyle, Density, CardCorner, CatalogLayout) and accent presets. AppFont ships SYSTEM/SERIF/MONO only for now - ROUNDED/CONDENSED need bundled, licensed .ttf assets this change does not add; deferred to a follow-up. - AppearancePreferences.kt: DataStore-backed persistence, following the ConsentPreferences pattern. Every read is defensive (corrupted/unknown enum values and out-of-range fontScale fall back to defaults instead of crashing). - AppearanceColorSchemes.kt / AppearanceTypography.kt: pure functions building a Material3 ColorScheme/Typography from AppearanceSettings. - Theme.kt: VRHubTheme now takes an AppearanceSettings param (defaulted, so existing @Preview call sites keep compiling) and exposes LocalAppearance for the handful of settings outside ColorScheme/ Typography (wired to card corner/density/catalog layout in a later PR). - AppearanceViewModel.kt: exposes settings as StateFlow + update/reset. - MainActivity.kt: collects settings and passes them to VRHubTheme. Only accent, font family and font scale are wired end-to-end in this PR; density/cardCorner/catalogLayout exist in the persisted model for schema stability but aren't consumed by any UI yet (PR3 of the feature breakdown).
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 43caa9c. |
PR Validation Summary ✅Status: All checks passed!
Reports and artifacts (including Lint HTML) are available in the Artifacts Tab of the Action Run Summary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objectif
Première tranche de la feature phare de personnalisation (
docs/sonnet5-specs/02-feature-appearance-customization.md), PR 1/5 du découpage proposé :feat/appearance-data-and-theme. Pose la couche données + thème ; aucun écran de réglages n'est ajouté dans cette PR, donc le comportement visible est inchangé (les valeurs par défaut reproduisent exactement le look actuel).Changements
ui/theme/AppearanceModels.kt:AppearanceSettings+ enums (ThemeMode,AppFont,BackgroundStyle,Density,CardCorner,CatalogLayout) et presets d'accent.AppFontn'expose queSYSTEM/SERIF/MONOpour l'instant —ROUNDED/CONDENSEDnécessitent des polices.ttfsous licence à bundler, non ajoutées ici (reporté à un suivi dédié).data/AppearancePreferences.kt: persistance DataStore, même pattern queConsentPreferences. Chaque lecture est défensive (valeur d'enum corrompue/inconnue etfontScalehors bornes retombent sur le défaut au lieu de planter).ui/theme/AppearanceColorSchemes.kt/AppearanceTypography.kt: fonctions pures construisant unColorScheme/TypographyMaterial3 à partir deAppearanceSettings.ui/theme/Theme.kt:VRHubThemeprend maintenant un paramètreAppearanceSettings(avec valeur par défaut, donc les@Previewexistants compilent toujours) et exposeLocalAppearancepour les réglages hors ColorScheme/Typography (câblés à densité/rayon de carte/vue catalogue dans une PR ultérieure).ui/AppearanceViewModel.kt: expose les settings enStateFlow+update/reset.MainActivity.kt: collecte les settings et les passe àVRHubTheme.Seuls l'accent, la police et l'échelle de texte sont câblés de bout en bout dans cette PR ;
density/cardCorner/catalogLayoutexistent dans le modèle persisté (pour la stabilité du schéma DataStore) mais ne sont consommés par aucune UI pour l'instant (PR 3 du découpage).Captures
Aucune différence visuelle attendue par défaut. Capture du smoke-test après installation : écran de configuration identique à la baseline documentée dans
00-environment-and-workflow.md(couleurs, disposition inchangées).Tests
AppearancePreferencesTest(round-trip de chaque champ,fontScaleborné à l'écriture,reset()efface tout, valeur d'enum corrompue → défaut, défauts ==AppearanceSettings()).AppearanceColorSchemesTest(défauts == ancienVrpColorSchemeexact, accent →secondary,themeMode/systemDark→ dark vs light,ACCENT_TINTEDproduit un fond distinct),AppearanceTypographyTest(famille appliquée à tous les styles, échelle multiplie bien les tailles, 1.0×/Default reproduit les tailles de base).scripts\gradlew.bat :app:assembleDevDebuget:app:testDevDebugUnitTest→ succès.Pixel_7,com.vrhub.debug) : lancement à froid sans crash, logcat propre, capture d'écran conforme à la baseline.Réf :
docs/sonnet5-specs/02-feature-appearance-customization.md§2, §8 (PR 1/5)