refactor: route top bar, drawer and Scaffold colors through the theme#67
Open
LeGeRyChEeSe wants to merge 1 commit into
Open
refactor: route top bar, drawer and Scaffold colors through the theme#67LeGeRyChEeSe wants to merge 1 commit into
LeGeRyChEeSe wants to merge 1 commit into
Conversation
Lot 1/4 of the hardcoded-color migration (docs/sonnet5-specs/02 §6), built on feat/appearance-layout-controls. Structural surfaces only (top bar, drawer, Scaffold background): - CustomTopBar: Surface background, all icon tints, sort dropdown item text, search field colors/placeholder/icons, and the shared labelColor/containerColor across every filter chip now read MaterialTheme.colorScheme instead of hardcoded Color(0xFF121212)/ Color.White/Color.Gray/Color.Black. - The two chips whose selected background is the actual accent (All, Local Installs) now use onSecondary for their selected text/icon instead of a hardcoded Color.Black, so a dark custom accent doesn't produce unreadable text. - ModalDrawerSheet background/content color, drawer title, version text, divider, and the unselected nav item colors now read the theme. - Scaffold containerColor: Color.Black -> colorScheme.background. Deliberately NOT touched (semantic, independent of theme, per doc): the monetization tier badge colors, and the per-filter status colors (New=red, Favorites=gold, Installed=blue, Downloaded=green, Updates=yellow) together with their matching selected text/icon color. All defaults are unchanged (colorScheme resolves to the exact same hex values as before for the default AppearanceSettings), so this is a no-visible-diff refactor until the user picks a non-default accent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objectif
Lot 1/4 de la migration des couleurs codées en dur (
docs/sonnet5-specs/02-feature-appearance-customization.md§6) : surfaces structurelles (barre supérieure, drawer,Scaffold). Dépend defeat/appearance-layout-controls(#66).Changements
CustomTopBar: fond de laSurface, teintes de toutes les icônes, texte des items du menu de tri, couleurs/placeholder/icônes du champ de recherche, etlabelColor/containerColorpartagés par tous les filter chips lisent maintenantMaterialTheme.colorSchemeau lieu deColor(0xFF121212)/Color.White/Color.Gray/Color.Blackcodés en dur.All,Local Installs) utilisent maintenantonSecondarypour leur texte/icône sélectionné au lieu d'unColor.Blackcodé en dur — un accent personnalisé sombre ne produit plus de texte illisible.ModalDrawerSheet: couleur de fond/contenu, titre, texte de version, séparateur, et couleurs des items de navigation non sélectionnés lisent le thème.Scaffold:containerColor:Color.Black→colorScheme.background.Volontairement non touché (sémantique, indépendant du thème, cf. doc)
Les couleurs du badge de palier de monétisation, et les couleurs de statut par filtre (New=rouge, Favorites=or, Installed=bleu, Downloaded=vert, Updates=jaune) ainsi que leur texte/icône sélectionné assorti.
Captures
Vérifié sur l'émulateur (
Pixel_7,com.vrhub.debug) avec l'accent Violet déjà sélectionné dans une PR précédente :Avec les réglages par défaut (
AppearanceSettings()),colorSchemerésout exactement les mêmes valeurs hexadécimales qu'avant migration — aucun changement visuel tant que l'utilisateur ne choisit pas un accent non-défaut.Tests
scripts\gradlew.bat :app:assembleDevDebuget:app:testDevDebugUnitTest→ succès (suite existante, aucune régression).AppearanceColorSchemesTest(PR1) pour la logique de résolution de couleur elle-même.Réf :
docs/sonnet5-specs/02-feature-appearance-customization.md§6 (Lot 1/4)