Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c0abd1ad6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "private": true, | ||
| "type": "module", | ||
| "packageManager": "bun@1.4.2", | ||
| "packageManager": "bun@1.4.4", |
There was a problem hiding this comment.
Update the locked Nix Bun package alongside the runtime pin
For Nix users, this pin no longer matches the Bun package supplied by the unchanged flake.lock: the locked nixpkgs revision still supplies 1.4.2, as documented before this change. flake.nix retains prev.bun on Linux and ARM Darwin, while Intel Darwin calls requireVersion on the same locked recipe before overriding its archive. Consequently, nix/toolchain.nix rejects the version mismatch when evaluating shells and packages on all four platforms. Update the locked input or provide a complete 1.4.4 package override; changing the Intel archive and README alone does not update the locked package version.
AGENTS.md reference: AGENTS.md:L22-L22
Useful? React with 👍 / 👎.
| "@types/braces": ["@types/braces@3.0.5", "", {}, "sha512-SQFof9H+LXeWNz8wDe7oN5zu7ket0qwMu5vZubW4GCJ8Kkeh6nBWUz87+KTz/G3Kqsrp0j/W253XJb3KMEeg3w=="], | ||
|
|
||
| "@types/bun": ["@types/bun@1.4.2", "https://registry.npmjs.org/@types/bun/-/bun-1.4.2.tgz", { "dependencies": { "bun-types": "1.4.2" } }, "sha512-GimotNn7+ZV0uVArItBbriZsR1oNf0+WTzPkdcFrzShI7k2norL0uzEaJT8T33dWr7O/c9ZDuAFQrctKCi72oQ=="], | ||
| "@types/bun": ["@types/bun@1.4.4", "https://registry.npmjs.org/@types/bun/-/bun-1.4.4.tgz", { "dependencies": { "bun-types": "1.4.4" } }, "sha512-9wkRDXUXK124pEnAutE6n/l18j+i9GC5IAHK8TmX/2nlySETmky0OU6yL5U8pW1AoKh++AN9auDCr647BfurjQ=="], |
There was a problem hiding this comment.
Regenerate the Nix dependency hashes for the updated Bun types
For native Nix package builds, updating @types/bun and its bun-types dependency changes the dependency output, but all four hashes in nix/hashes.json remain unchanged. nix/node_modules.nix installs the opencode, desktop, and app workspaces, each of which depends on @types/bun, and checks the resulting directory against those fixed recursive hashes. Once the runtime-version mismatch is corrected, fresh dependency builds will therefore fail with a hash mismatch. Measure and commit the new per-platform hashes using the existing native verification workflow.
AGENTS.md reference: AGENTS.md:L22-L22
Useful? React with 👍 / 👎.
|
Closing: tooling-only Bun pin with 9 failing checks and two open P1 findings (flake.lock and Nix dependency hashes not updated). A future Bun bump should land together with the Nix lock and hashes. |
Why
Pin the latest stable Bun (1.4.4, 2026-10-22) so CI, the Nix shell and local machines share one version.
Closes #902
What changed
packageManagerand@types/buninpackage.json, andpackageManagerinsdks/vscode/package.json, now name Bun 1.4.4. CI reads this pin, so the CI toolchain moves with it.flake.nixdownloads the Intel macOS baseline build of 1.4.4; the hash comes from the release'sSHASUMS256.txt.bun.lockchanges only the@types/bunandbun-typesentries (integrity from the npm registry). A localbun installwas not committed because it rewrites unrelated registry URLs.nix/README.mdandscript/toolchain.test.mjsfollow the new pin.Evidence
node --test script/toolchain.test.mjs: 8 passed.bun install --frozen-lockfile: accepted the edited lockfile.openai-request-headerstransport-body tests that fail on Bun 1.4.3. CI on 1.4.4 is the first run of both; if those tests still fail there, the fix goes into this PR.Checklist
🤖 Generated with Claude Code