Skip to content

Give the sample movies recognisable titles and add review text - #58

Merged
stphnwlsh merged 2 commits into
mainfrom
fix/recognisable-seed-titles
Nov 6, 2026
Merged

stphnwlsh merged 2 commits into
mainfrom
fix/recognisable-seed-titles

Conversation

@stphnwlsh

@stphnwlsh stphnwlsh commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The sample movies were corporate buzzword phrases, so a search like "space" found nothing. They're now 50 made-up titles across genres, and searches for "space", "love", "murder" and "dragon" each find four. Reviews also get optional text, up to 1000 characters, with a migration, validation and sample text, on every way of creating or reading a review here. The seed's ids change, so the README samples are regenerated.

The same change in the other templates: Minimal API, MCP, Web API, Lambda Function.

Related issues

None.

Type of change

  • Bug fix
  • New feature
  • Breaking change (the generated solution or template parameters change in a way existing users will notice)
  • Refactoring or clean-up
  • Documentation
  • Build, pipeline or dependency update

Shared layers

  • This only touches the Presentation layer of this template.
  • This touches the Application or Infrastructure layers, tests, pipeline or repository setup, so it needs to be carried across all five templates.

Checklist

  • dotnet build and dotnet test pass locally with no warnings.
  • I added or updated tests, and line coverage stays at or above 95%.
  • I updated the README or docs where behaviour changed.
  • If this changes how we do something, I updated the matching skill in .agents/skills.
  • I checked the template still installs and creates a working solution (see CONTRIBUTING.md).

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Build Pipeline

✅ Ready to merge. Every stage passed.

Stage Result Details
Build 🟢 Passed Version 2026.11.06.204-pr-58 · Template package 232 KB
Test 🟢 Passed 226 passed · 0 failed · 0 skipped · Template installs, builds and passes its tests
Coverage 🟢 Passed 100% (749 of 749 lines) · Needs 95%
Static Analysis 🟢 Passed No open CodeQL alerts
Dependency Review 🟢 Passed 0 vulnerable packages · 0 licence problems
Container Scan 🟢 Passed Image starts and answers · No open Trivy alerts

Commit 234b588 · Full run

stphnwlsh added a commit to LeanMeanCleanApps/CleanWebApi that referenced this pull request Nov 6, 2026
## Summary

The sample movies were corporate buzzword phrases, so a search like
"space" found nothing. They're now 50 made-up titles across genres, and
searches for "space", "love", "murder" and "dragon" each find four.
Reviews also get optional text, up to 1000 characters, with a migration,
validation and sample text, on every way of creating or reading a review
here. The seed's ids change, so the README samples are regenerated.

The same change in the other templates: [Minimal
API](LeanMeanCleanApps/CleanMinimalApi#78),
[MCP](LeanMeanCleanApps/CleanModelContextProtocol#56),
[GraphQL](LeanMeanCleanApps/CleanGraphQLApi#58),
[Lambda
Function](LeanMeanCleanApps/CleanLambdaFunction#47).

## Related issues

None.

## Type of change

- [ ] Bug fix
- [x] New feature
- [ ] Breaking change (the generated solution or template parameters
change in a way existing users will notice)
- [ ] Refactoring or clean-up
- [ ] Documentation
- [ ] Build, pipeline or dependency update

## Shared layers

- [ ] This only touches the Presentation layer of this template.
- [x] This touches the Application or Infrastructure layers, tests,
pipeline or repository setup, so it needs to be carried across all five
templates.

## Checklist

- [x] `dotnet build` and `dotnet test` pass locally with no warnings.
- [ ] I added or updated tests, and line coverage stays at or above 95%.
- [x] I updated the README or docs where behaviour changed.
- [x] If this changes how we do something, I updated the matching skill
in `.agents/skills`.
- [ ] I checked the template still installs and creates a working
solution (see CONTRIBUTING.md).
stphnwlsh added a commit to LeanMeanCleanApps/CleanLambdaFunction that referenced this pull request Nov 6, 2026
## Summary

The sample movies were corporate buzzword phrases, so a search like
"space" found nothing. They're now 50 made-up titles across genres, and
searches for "space", "love", "murder" and "dragon" each find four.
Reviews also get optional text, up to 1000 characters, with a migration,
validation and sample text, on every way of creating or reading a review
here. The seed's ids change, so the README samples are regenerated.

The same change in the other templates: [Minimal
API](LeanMeanCleanApps/CleanMinimalApi#78),
[MCP](LeanMeanCleanApps/CleanModelContextProtocol#56),
[GraphQL](LeanMeanCleanApps/CleanGraphQLApi#58),
[Web API](LeanMeanCleanApps/CleanWebApi#52).

## Related issues

None.

## Type of change

- [ ] Bug fix
- [x] New feature
- [ ] Breaking change (the generated solution or template parameters
change in a way existing users will notice)
- [ ] Refactoring or clean-up
- [ ] Documentation
- [ ] Build, pipeline or dependency update

## Shared layers

- [ ] This only touches the Presentation layer of this template.
- [x] This touches the Application or Infrastructure layers, tests,
pipeline or repository setup, so it needs to be carried across all five
templates.

## Checklist

- [x] `dotnet build` and `dotnet test` pass locally with no warnings.
- [ ] I added or updated tests, and line coverage stays at or above 95%.
- [x] I updated the README or docs where behaviour changed.
- [x] If this changes how we do something, I updated the matching skill
in `.agents/skills`.
- [ ] I checked the template still installs and creates a working
solution (see CONTRIBUTING.md).
stphnwlsh added a commit to LeanMeanCleanApps/CleanModelContextProtocol that referenced this pull request Nov 6, 2026
## Summary

The sample movies were corporate buzzword phrases, so a search like
"space" found nothing. They're now 50 made-up titles across genres, and
searches for "space", "love", "murder" and "dragon" each find four.
Reviews also get optional text, up to 1000 characters, with a migration,
validation and sample text, on every way of creating or reading a review
here. The seed's ids change, so the README samples are regenerated.

The same change in the other templates: [Minimal
API](LeanMeanCleanApps/CleanMinimalApi#78),
[GraphQL](LeanMeanCleanApps/CleanGraphQLApi#58),
[Web API](LeanMeanCleanApps/CleanWebApi#52),
[Lambda
Function](LeanMeanCleanApps/CleanLambdaFunction#47).

## Related issues

None.

## Type of change

- [ ] Bug fix
- [x] New feature
- [ ] Breaking change (the generated solution or template parameters
change in a way existing users will notice)
- [ ] Refactoring or clean-up
- [ ] Documentation
- [ ] Build, pipeline or dependency update

## Shared layers

- [ ] This only touches the Presentation layer of this template.
- [x] This touches the Application or Infrastructure layers, tests,
pipeline or repository setup, so it needs to be carried across all five
templates.

## Checklist

- [x] `dotnet build` and `dotnet test` pass locally with no warnings.
- [ ] I added or updated tests, and line coverage stays at or above 95%.
- [x] I updated the README or docs where behaviour changed.
- [x] If this changes how we do something, I updated the matching skill
in `.agents/skills`.
- [ ] I checked the template still installs and creates a working
solution (see CONTRIBUTING.md).
@stphnwlsh
stphnwlsh added this pull request to stack #60 November 6, 2026 21:01
@stphnwlsh
stphnwlsh merged commit 3dd98df into main Nov 6, 2026
13 checks passed
@stphnwlsh
stphnwlsh deleted the fix/recognisable-seed-titles branch November 6, 2026 21:01
stphnwlsh added a commit to LeanMeanCleanApps/CleanMinimalApi that referenced this pull request Nov 6, 2026
## Summary

The sample movies were corporate buzzword phrases, so a search like
"space" found nothing. They're now 50 made-up titles across genres, and
searches for "space", "love", "murder" and "dragon" each find four.
Reviews also get optional text, up to 1000 characters, with a migration,
validation and sample text, on every way of creating or reading a review
here. The seed's ids change, so the README samples are regenerated.

The same change in the other templates:
[MCP](LeanMeanCleanApps/CleanModelContextProtocol#56),
[GraphQL](LeanMeanCleanApps/CleanGraphQLApi#58),
[Web API](LeanMeanCleanApps/CleanWebApi#52),
[Lambda
Function](LeanMeanCleanApps/CleanLambdaFunction#47).

## Related issues

None.

## Type of change

- [ ] Bug fix
- [x] New feature
- [ ] Breaking change (the generated solution or template parameters
change in a way existing users will notice)
- [ ] Refactoring or clean-up
- [ ] Documentation
- [ ] Build, pipeline or dependency update

## Shared layers

- [ ] This only touches the Presentation layer of this template.
- [x] This touches the Application or Infrastructure layers, tests,
pipeline or repository setup, so it needs to be carried across all five
templates.

## Checklist

- [x] `dotnet build` and `dotnet test` pass locally with no warnings.
- [ ] I added or updated tests, and line coverage stays at or above 95%.
- [x] I updated the README or docs where behaviour changed.
- [x] If this changes how we do something, I updated the matching skill
in `.agents/skills`.
- [ ] I checked the template still installs and creates a working
solution (see CONTRIBUTING.md).
stphnwlsh added a commit that referenced this pull request Nov 6, 2026
## Summary

Reviews have text now, so you can search it. Listing reviews takes a
search term that matches the review text, ignoring case, and a minimum
star rating, on top of the existing movie and author filters. It's one
shared Application change, exposed here as `query` and `minStars`
arguments on `reviews`.

This is stacked on the seed pull request,
#58, and will
retarget to `main` when that merges.

The same change in the other templates: [Minimal
API](LeanMeanCleanApps/CleanMinimalApi#79),
[MCP](LeanMeanCleanApps/CleanModelContextProtocol#57),
[Web API](LeanMeanCleanApps/CleanWebApi#53),
[Lambda
Function](LeanMeanCleanApps/CleanLambdaFunction#48).

## Related issues

None.

## Type of change

- [ ] Bug fix
- [x] New feature
- [ ] Breaking change (the generated solution or template parameters
change in a way existing users will notice)
- [ ] Refactoring or clean-up
- [ ] Documentation
- [ ] Build, pipeline or dependency update

## Shared layers

- [ ] This only touches the Presentation layer of this template.
- [x] This touches the Application or Infrastructure layers, tests,
pipeline or repository setup, so it needs to be carried across all five
templates.

## Checklist

- [x] `dotnet build` and `dotnet test` pass locally with no warnings.
- [ ] I added or updated tests, and line coverage stays at or above 95%.
- [x] I updated the README or docs where behaviour changed.
- [x] If this changes how we do something, I updated the matching skill
in `.agents/skills`.
- [ ] I checked the template still installs and creates a working
solution (see CONTRIBUTING.md).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant