Skip to content

chore: remove dead code, unused packages and leftover config - #23

Merged
stphnwlsh merged 1 commit into
mainfrom
chore/remove-dead-code
Oct 28, 2026
Merged

stphnwlsh merged 1 commit into
mainfrom
chore/remove-dead-code

Conversation

@stphnwlsh

@stphnwlsh stphnwlsh commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Removes dead code, unused packages and leftover config. Application and Infrastructure stay identical across all five templates, and the pipeline and Dockerfile changes are the same in each repo.

  • Removed the unreachable elif that compared the event name with the default branch, the unused branch output and the docker_tag output left over from Docker pushes. The image is tagged with version only and no longer gets a latest tag, since nothing pushes it. Version numbers are unchanged.
  • Removed the ARG CACHE_BUST line from the Dockerfile. Nothing set it.
  • Removed InternalsVisibleTo from Application (it has no internal types) and the DynamicProxyGenAssembly2 entry from Infrastructure (its tests don't use NSubstitute).
  • Removed NSubstitute from Infrastructure.Tests.Integration, which never uses it.
  • Removed the unused Serilog.Enrichers.Thread package (nothing enriches with thread ids) and the empty RunConfiguration property group from Presentation.csproj.
  • Deleted Logging/ApplicationLog.cs. None of its LoggerMessage methods were called.
  • Stopped copying icon.png into the Presentation output. The server icon is served from the GitHub URL and the package icon comes from template.csproj.
  • Removed NSubstitute from Presentation.Tests.Integration and the unused Serialize test helper.

Type of change

  • Bug fix
  • New feature
  • Breaking change (the generated solution or template parameters change in a way existing users will notice)
  • Refactoring or clean-up
  • Documentation
  • Build, pipeline or dependency update

Shared layers

  • This only touches the Presentation layer of this template.
  • This touches the Application or Infrastructure layers, tests, pipeline or repository setup, so it needs to be carried across all five templates.

Checklist

  • dotnet build and dotnet test pass locally with no warnings.
  • I added or updated tests, and coverage stays at or above 95%.
  • I updated the README or docs where behaviour changed.
  • I checked the template still installs and creates a working solution (see CONTRIBUTING.md).

@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.97%. Comparing base (b169bfc) to head (162de2e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files          68       68           
  Lines         686      686           
  Branches       41       41           
=======================================
  Hits          679      679           
  Partials        7        7           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stphnwlsh
stphnwlsh merged commit 771fb83 into main Oct 28, 2026
12 checks passed
@stphnwlsh
stphnwlsh deleted the chore/remove-dead-code branch October 28, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant