Repository navigation
chore: remove dead code, unused packages and leftover config - #23
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=======================================
Coverage 98.97% 98.97%
=======================================
Files 68 68
Lines 686 686
Branches 41 41
=======================================
Hits 679 679
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes dead code, unused packages and leftover config. Application and Infrastructure stay identical across all five templates, and the pipeline and Dockerfile changes are the same in each repo.
elifthat compared the event name with the default branch, the unusedbranchoutput and thedocker_tagoutput left over from Docker pushes. The image is tagged withversiononly and no longer gets alatesttag, since nothing pushes it. Version numbers are unchanged.ARG CACHE_BUSTline from the Dockerfile. Nothing set it.InternalsVisibleTofrom Application (it has no internal types) and theDynamicProxyGenAssembly2entry from Infrastructure (its tests don't use NSubstitute).Serilog.Enrichers.Threadpackage (nothing enriches with thread ids) and the emptyRunConfigurationproperty group from Presentation.csproj.Logging/ApplicationLog.cs. None of its LoggerMessage methods were called.icon.pnginto the Presentation output. The server icon is served from the GitHub URL and the package icon comes from template.csproj.Serializetest helper.Type of change
Shared layers
Checklist
dotnet buildanddotnet testpass locally with no warnings.