Repository navigation
Write null fields so tool results match their output schemas - #49
Merged
Merged
Conversation
Contributor
Build Pipeline✅ Ready to merge. Every stage passed.
Commit |
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tool results left out null fields, but the output schemas list them as required. The last page of any search or list had no
nextOffset, so strict clients such as Open WebUI's MCP client rejected the result. The serializer now writes nulls. It has to sayJsonIgnoreCondition.Neveroutright, because the options start from the SDK's defaults, which also drop nulls.AverageStarsand the movie and author fields onReviewResultnow come through as null too.The conformance check still reports one failure: a
2025-11-25MCP-Protocol-Versionheader on a2026-07-28request gets HTTP 200 and-32601, not 400 and-32020. The SDK treats the older header as a legacy request before anything compares the two. 2.3.1 does the same, so that one stays open here.Related issues
None.
Type of change
Shared layers
Checklist
dotnet buildanddotnet testpass locally with no warnings..agents/skills.