Skip to content

Dispose CancellationTokenSource in tests - #9

Merged
stphnwlsh merged 1 commit into
mainfrom
chore/dispose-test-tokens
Oct 27, 2026
Merged

stphnwlsh merged 1 commit into
mainfrom
chore/dispose-test-tokens

Conversation

@stphnwlsh

@stphnwlsh stphnwlsh commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

CodeQL flags every new CancellationTokenSource().Token in the tests as a missing Dispose call. The tests now create the source with a using declaration. The same change is going into the other four templates so the shared test projects stay identical.

CodeQL flags each undisposed CancellationTokenSource. Create them with
a using declaration instead.
@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.71%. Comparing base (dd04643) to head (14f8b7a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files          39       39           
  Lines         356      356           
  Branches        8        8           
=======================================
  Hits          355      355           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stphnwlsh
stphnwlsh merged commit 422c323 into main Oct 27, 2026
12 checks passed
@stphnwlsh
stphnwlsh deleted the chore/dispose-test-tokens branch October 27, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant