docs(claude): fix build/test commands and file layout in CLAUDE.md#1243
docs(claude): fix build/test commands and file layout in CLAUDE.md#1243cristim wants to merge 1 commit into
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 12 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
The Build & Test section instructed npm run build / npm test / npm run lint at the repo root, where no package.json exists; the root build is Go. The File Organization section mandated /src, /tests, /config, /examples directories that do not exist in this repo. Replace both sections with the real commands (go build ./... and go test ./... at the root, make build / make test-unit / make lint, npm scripts under frontend/) and the actual directory layout (cmd/, internal/, pkg/, providers/, frontend/, terraform/, docs/, scripts/, tests/). All documented commands verified against the Makefile and frontend/package.json; go build ./... run successfully at the root. No other sections changed. Closes #1179
Problem
CLAUDE.md, the highest-priority instruction file for every agent session, contained two factually wrong sections (review finding HYG-10):
npm run build/npm test/npm run lintat the repo root, where nopackage.jsonexists; the root build is Go./src,/tests(as generic test dir),/config,/examplesdirectories that do not exist; the real layout iscmd/,internal/,pkg/,providers/,frontend/,terraform/, etc.Fix
Replaced only the factual errors, preserving the rest of the file:
go build ./.../go test ./...at the root (with themake build/make test-unit/make lintequivalents), and the npm scripts (npm run build,npm test,npm run lint) underfrontend/.cmd/,internal/,pkg/,providers/,frontend/,terraform//cloudformation//arm//iac/,docs/,scripts/,tests/(e2e).No other sections were changed.
Verification
Makefiletargets (build,test-unit,lintexist and run go build/go test/golangci-lint) andfrontend/package.jsonscripts (build,test,lintexist).internal/contents.go build ./...run successfully at the repo root of this branch.Closes #1179