log: silence 'service config not found' on per-rec lookup (closes #263) by cristim · Pull Request #863 · LeanerCloud/CUDly

cristim · 2026-05-30T17:36:28Z

Summary

PostgresStore.GetServiceConfig was returning a plain error on pgx.ErrNoRows, not wrapping ErrNotFound, so globalConfigCache.lookup propagated it as a real error on every recommendation refresh for services without a global config row.
Wrap the no-rows path as %w ErrNotFound in both PostgresStore.GetServiceConfig (production) and the testablePostgresStore mock so callers get a consistent sentinel.
In globalConfigCache.lookup, use errors.Is(err, ErrNotFound) to treat the absent-config case as (nil, nil) rather than returning an error, silencing the INFO log noise on each refresh cycle.

Test plan

go build ./... clean
go test github.com/LeanerCloud/CUDly/internal/api/... github.com/LeanerCloud/CUDly/internal/config/... passes (1906 tests)
TestGetServiceConfig_NotFound still asserts assert.Error + assert.Contains("not found") -- both hold because the wrapped error message still contains "not found"
TestResolveAccountConfigsForRecs_GlobalAbsentCachedNegative confirms the absent-global case is cached as missing (no second fetch) with no error returned

Closes #263.

cristim · 2026-05-30T17:36:36Z

@coderabbitai review

coderabbitai · 2026-05-30T17:36:38Z

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 10 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 72a3667c-a37f-4d45-a8d3-1bff95d5f7b9

📥 Commits

Reviewing files that changed from the base of the PR and between 1d9f1b8 and 6c25450.

📒 Files selected for processing (4)

internal/config/recommendation_overrides.go
internal/config/recommendation_overrides_test.go
internal/config/store_postgres.go
internal/config/store_postgres_mock_test.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/263-wave18

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai · 2026-05-30T17:36:41Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim · 2026-06-02T00:30:57Z

@coderabbitai review

coderabbitai · 2026-06-02T00:31:02Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim · 2026-06-04T14:03:13Z

@coderabbitai review

coderabbitai · 2026-06-04T14:03:27Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim · 2026-06-08T08:44:59Z

@coderabbitai full review

Generated by Claude Code

coderabbitai · 2026-06-08T08:45:10Z

@cristim Sure, I'll kick off a full review of PR #863 right away!

🧠 Learnings used

Learnt from: cristim
Repo: LeanerCloud/CUDly PR: 0
File: :0-0
Timestamp: 2026-05-05T15:44:54.463Z
Learning: In the LeanerCloud/CUDly repository, when a CodeRabbit review flags something as "outside-diff" that was already implemented in an earlier commit of the same PR, it is likely a stale-snapshot artifact where the review diff was generated against a pre-fix view. The inline comment convention `(CR pass on PR #<number> Finding N)` is used by the maintainer (cristim) to mark lines that were changed in direct response to a prior CodeRabbit review pass.

Learnt from: cristim
Repo: LeanerCloud/CUDly PR: 0
File: :0-0
Timestamp: 2026-06-07T18:28:28.139Z
Learning: In LeanerCloud/CUDly `providers/gcp/recommendations.go`, `collectRegion` fans out to all four GCP service clients (computeengine, cloudsql, memorystore, cloudstorage) concurrently (fixed in PR `#1047` commit 95a390f, H-2 finding). `regionResult` gains `cache` and `storage` slices; merge is updated accordingly. The decision was to wire (not trim) memorystore and cloudstorage because both have complete `GetRecommendations` implementations and their no-op `PurchaseCommitment` paths are orthogonal to surfacing advisory recommendations. Regression tests: `TestRegionResult_HasCacheAndStorageFields` and `TestShouldIncludeService_Cache_Storage`.

Learnt from: cristim
Repo: LeanerCloud/CUDly PR: 0
File: :0-0
Timestamp: 2026-06-07T18:28:28.139Z
Learning: In LeanerCloud/CUDly GCP service clients (computeengine, cloudsql, memorystore, cloudstorage), `GetRecommendations` filters out non-ACTIVE recommendations using the typed `recommenderpb.RecommendationStateInfo_ACTIVE` enum (CLAIMED/SUCCEEDED/FAILED/DISMISSED are skipped). State is accessed nil-safely via the proto getter. Fixed in PR `#1047` commit 95a390f (H-1 finding). Regression tests: `TestGetRecommendations_FiltersNonActiveStates` (5-rec mock, only ACTIVE survives) and `TestGetRecommendations_ActiveRecIncluded`. Existing mock tests in all four services had StateInfo added to satisfy the new filter.

Learnt from: cristim
Repo: LeanerCloud/CUDly PR: 0
File: :0-0
Timestamp: 2026-06-07T19:32:26.182Z
Learning: In LeanerCloud/CUDly `providers/aws/services/rds/client.go`, `findOfferingID` validates AZConfig with a switch that has a `default: error` case covering non-empty invalid values (e.g. "typo-az"), not just an empty-string check. A bad non-empty AZConfig previously fell through to `multiAZ==false` in `paginateRDSOfferings` (same mis-buy as the old default). Fixed in PR `#1085` commit 681fd9e81. Regression test added.

Learnt from: cristim
Repo: LeanerCloud/CUDly PR: 0
File: :0-0
Timestamp: 2026-06-07T17:38:19.433Z
Learning: In LeanerCloud/CUDly GCP service converters (`convertGCPRecommendation` in memorystore/client.go and cloudstorage/client.go), `rec.Term` must be derived from `params.Term` with a `"1yr"` default — not hardcoded to `"1yr"`. Without this, 3-year callers always emit 1-year commitments even though the downstream `termYears` derivation from `rec.Term` is correct. Fixed in PR `#1047` commit c6280c390 (F2 for memorystore, F4 for cloudstorage). Regression tests: `TestConvertGCPRecommendation_PropagatesTermFromParams` and `TestCloudStorageConvertGCPRecommendation_PropagatesTermFromParams`.

Learnt from: cristim
Repo: LeanerCloud/CUDly PR: 0
File: :0-0
Timestamp: 2026-06-05T12:28:20.800Z
Learning: In LeanerCloud/CUDly, `internal/mocks/stores.go` is the canonical `MockConfigStore` (testify/mock embedding, Fn-override fields, isExpected guards). Per-package files in `internal/api`, `internal/purchase`, and `internal/scheduler` were reduced to a single type alias line: `type MockConfigStore = mocks.MockConfigStore`. Four intentionally-local mocks remain: `mockConfigStore` (lowercase, hook-field only) in `internal/analytics/collector_test.go`; `mockConfigStoreForHealth` in `internal/server/test_helpers_test.go`; and `mockConfigStoreForExchange` / per-scenario variants in `internal/server/handler_ri_exchange_test.go` and `handler_coverage_test.go`. A compile-time check `var _ config.StoreInterface = (*MockConfigStore)(nil)` lives in the shared mock.

✅ Action performed

Full review finished.

cristim · 2026-06-08T09:05:28Z

@coderabbitai full review

coderabbitai · 2026-06-08T09:06:19Z

✅ Action performed

Full review finished.

cristim · 2026-06-19T21:48:22Z

@coderabbitai review

coderabbitai · 2026-06-19T21:48:27Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim · 2026-07-10T15:33:49Z

@coderabbitai review

coderabbitai · 2026-07-10T15:33:55Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim · 2026-07-10T22:10:48Z

@coderabbitai review

coderabbitai · 2026-07-10T22:10:53Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim · 2026-07-17T08:02:29Z

@coderabbitai review

coderabbitai · 2026-07-17T08:02:53Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim · 2026-07-17T11:24:56Z

Rebased onto main (includes #1437 tflint cache + #1438 trivy skip). Gate results: go build exit 0, go vet exit 0, gocyclo on internal/config exit 0, go test ./internal/config/... 643 passed.

GetServiceConfig now wraps pgx.ErrNoRows as ErrNotFound so callers can distinguish "no row" from a real DB error. globalConfigCache.lookup uses errors.Is to treat ErrNotFound as (nil,nil) instead of propagating it, stopping the INFO noise emitted on every refresh for unconfigured services.

…lookup regression test - Replace bare == comparisons with errors.Is(err, pgx.ErrNoRows) in GetGlobalConfig, GetServiceConfig, diagnoseTransitionFailure, GetCloudAccount, GetCloudAccountByExternalID, GetAccountCredential, and GetAccountServiceOverride to satisfy errorlint. - Apply the same fix to testablePostgresStore helpers in the mock test (GetGlobalConfig, GetServiceConfig, GetPurchasePlan). - Name the return values of appendAccountPredicate to satisfy gocritic unnamedResult. - Add TestResolveAccountConfigsForRecs_ErrNotFoundAbsorbed to exercise the ErrNotFound-from-GetServiceConfig path through globalConfigCache.lookup (the root scenario of #263: absent global config row must not propagate as an error to the caller).

cristim added triaged Item has been triaged priority/p3 Polish / idea / may never ship severity/low Minor harm urgency/eventually No deadline impact/internal Team-internal only effort/s Hours type/bug Defect labels May 30, 2026

cristim force-pushed the fix/263-wave18 branch from fbf8092 to a5d5155 Compare June 1, 2026 17:26

cristim changed the base branch from feat/multicloud-web-frontend to main June 9, 2026 15:43

cristim force-pushed the fix/263-wave18 branch from a5d5155 to f8f8fb5 Compare June 19, 2026 21:48

cristim force-pushed the fix/263-wave18 branch from f8f8fb5 to 8a99c8e Compare July 10, 2026 15:33

cristim force-pushed the fix/263-wave18 branch from 8a99c8e to 2c7e9d0 Compare July 10, 2026 22:10

cristim force-pushed the fix/263-wave18 branch from 2c7e9d0 to dfd22bb Compare July 17, 2026 08:02

cristim force-pushed the fix/263-wave18 branch from dfd22bb to 0be2874 Compare July 17, 2026 11:24

cristim added 2 commits July 17, 2026 21:13

cristim force-pushed the fix/263-wave18 branch from 0be2874 to 6c25450 Compare July 17, 2026 18:14

Uh oh!

Conversation

cristim commented May 30, 2026

Summary

Test plan

Uh oh!

cristim commented May 30, 2026

Uh oh!

coderabbitai Bot commented May 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

coderabbitai Bot commented May 30, 2026

Uh oh!

cristim commented Jun 2, 2026

Uh oh!

coderabbitai Bot commented Jun 2, 2026

Uh oh!

cristim commented Jun 4, 2026

Uh oh!

coderabbitai Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cristim commented Jun 8, 2026

Uh oh!

coderabbitai Bot commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cristim commented Jun 8, 2026

Uh oh!

coderabbitai Bot commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cristim commented Jun 19, 2026

Uh oh!

coderabbitai Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cristim commented Jul 10, 2026

Uh oh!

coderabbitai Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cristim commented Jul 10, 2026

Uh oh!

coderabbitai Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cristim commented Jul 17, 2026

Uh oh!

coderabbitai Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cristim commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai Bot commented May 30, 2026 •

edited

Loading

coderabbitai Bot commented Jun 4, 2026 •

edited

Loading

coderabbitai Bot commented Jun 8, 2026 •

edited

Loading

coderabbitai Bot commented Jun 8, 2026 •

edited

Loading

coderabbitai Bot commented Jun 19, 2026 •

edited

Loading

coderabbitai Bot commented Jul 10, 2026 •

edited

Loading

coderabbitai Bot commented Jul 10, 2026 •

edited

Loading

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading