test(archera): extend federation handler matrix to CLI/ARM (closes #316)#890
test(archera): extend federation handler matrix to CLI/ARM (closes #316)#890cristim wants to merge 1 commit into
Conversation
cristim
added
triaged
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 8 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai full review Generated by Claude Code |
|
🧠 Learnings used✅ Action performedFull review finished. |
|
@coderabbitai full review |
✅ Action performedFull review finished. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Add table-driven test matrix for all CLI target/source combinations, ARM renders across source-cloud variants, single-file render shape invariants, and a dedicated Archera default-off regression guard. New tests: - TestGetFederationIaC_CLIMatrix: 8 target/source cases verifying content-type (text/x-shellscript), no ContentEncoding, bash shebang, canonical purchase+read actions for AWS-target, and no PII outside CONTACT_EMAIL assignment. - TestGetFederationIaC_ARMMatrix: 2 source variants verifying ARM JSON schema, parameters/resources/outputs structure, Reservation Purchaser role definition ID, no Archera references. - TestGetFederationIaC_SingleFileRenderShape: invariant that CLI renders are plain text with no base64 encoding. - TestGetFederationIaC_CLIArcheraDefaultOff: dedicated regression guard asserting Archera is absent from all 5 CLI formats by default.
1 participant
Summary
TestGetFederationIaC_CLIMatrix: table-driven test over all 8 CLI target/source combos asserting content-type, no ContentEncoding (single-file shape), bash shebang, canonical purchase+read actions for AWS-target, Archera default-off, and PII guard (email not leaked outside CONTACT_EMAIL assignment)TestGetFederationIaC_ARMMatrix: ARM render coverage for source=aws and source=gcp, asserting ARM JSON schema validity, parameters/resources/outputs structure, Reservation Purchaser role definition ID, no Archera references in any artifactTestGetFederationIaC_SingleFileRenderShape: invariant that CLI renders produce plain text with no base64/ContentEncodingTestGetFederationIaC_CLIArcheraDefaultOff: dedicated regression guard for all 5 CLI formatsTest plan
go test ./internal/api/... -run TestGetFederationIaC_CLIMatrix- 8 sub-cases passgo test ./internal/api/... -run TestGetFederationIaC_ARMMatrix- 2 sub-cases passgo test ./internal/api/... -run TestGetFederationIaC_SingleFileRenderShape- passesgo test ./internal/api/... -run TestGetFederationIaC_CLIArcheraDefaultOff- 5 sub-cases passgo test ./internal/api/...- all 1374 tests pass (no regressions)