Repository navigation
refactor(cmd): split configure_azure.go by concern - #2292
Merged
Merged
Conversation
…e.go Pure move of newAzureWizardCredential and listAzureSubscriptions into configure_azure_subs.go. No behaviour change. Part of #1834. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pure move of runAzureSetupCommands and the login, subscription and tenant steps into configure_azure_setup.go. No behaviour change. Part of #1834. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ure.go Pure move of azureStepCreateServicePrincipal and its result and recovery-hint helpers into configure_azure_sp_step.go. No behaviour change. Part of #1834. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ure.go Pure move of promptAndRunExplicitCommand and executeExplicitCommand into configure_azure_exec.go. No behaviour change. Part of #1834. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reached
This review includes 5 billable files and costs up to $1.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 37 minutes for your next included review. View limit details
Comment |
The moved exec.Command calls live in configure_{gcp,azure}_{exec,setup}.go, so widen the per-file noctx exclusion to match.
Part of #1834.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
Member
Author
Merge gate verdict (claude-cc-libs)Every gate holds at head bb0663a:
CodeRabbit is waived as a merge gate under the 2026-10-19 decision. Squash-merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure-move split of cmd/configure_azure.go into concern-focused files (part of #1834).
Part of #1834.
AST proof: a go/ast dump of every top-level declaration with its doc comment and free-floating comments across cmd/*.go (non-test) was byte-identical to origin/main at every commit (checked after each commit). go vet ./cmd/... and go test -count=1 ./cmd/... pass.
🤖 Generated with Claude Code