[cristim]

Summary

• Wrap common.ErrCurrencyNotAccepted (added in feat(common): add ErrCurrencyNotAccepted #640) with %w at every Azure currency refusal: reservations.CheckCurrency (reservation purchases via checkBillingCurrency, and compute CalculateExchange) and the savings plan purchaseOrderBody mismatch check. Each existing message gains a : currency not accepted suffix.
• Callers can use errors.Is(err, common.ErrCurrencyNotAccepted) to tell a refusal from an API failure.
• A separate commit bumps providers/azure's pkg pin so it builds with GOWORK=off.

Tests

• errors.Is holds for a reservation purchase refusal, a savings plan refusal and an exchange refusal; non-currency errors do not match.
• Mutation probe: dropping %w at the savings plan site or in CheckCurrency fails the tests.
• go test -race -count=1 ./... in providers/azure passes with GOWORK=off and in the workspace; lint clean.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

• Run on-demand review

_{This review includes 7 billable files and costs up to $1.75.}

• Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 36 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 63 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: LeanerCloud/cloud-commitments-go
• Branch: feat/currency-refusal-sentinel
• File: .coderabbit.yaml
• Commit: 4404b25
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Essentials
• Run ID: 674d62c7-2a43-4070-a22a-a6105c470d27

Commits

Reviewing files that changed from the base of the PR and between 2262c7b and 4404b25.

Files ignored due to path filters: 1

• providers/azure/go.sum is excluded by !**/*.sum

Files selected for processing: 7

• CHANGELOG.md
• providers/azure/go.mod
• providers/azure/services/compute/exchange_operations_test.go
• providers/azure/services/internal/reservations/purchase.go
• providers/azure/services/internal/reservations/purchasecurrency_test.go
• providers/azure/services/savingsplans/client.go
• providers/azure/services/savingsplans/client_test.go

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[cristim]

Review verdicts at 328c5e9: two independent cold reviews (non-author), both APPROVE, after a rebase onto #640 and a CHANGELOG fix.

• Every Azure currency refusal wraps common.ErrCurrencyNotAccepted with %w. CheckCurrency (purchase.go:245, :252) reaches all 7 reservation PurchaseCommitment results unwrapped through purchaseTwoStepGuarded (%w, on every retry), DoIdempotentPurchaseTwoStep and Submit. The compute exchange refusal (exchange_operations.go:285) and the savings plan check (client.go:449) also wrap with %w. The format check on caller input (client.go:340) stays unwrapped. Non-currency failures do not match.
• Each refusal message gains a : currency not accepted suffix; detect it with errors.Is.
• providers/azure bumps pkg to v0.0.0-20261026141505-6c5673cd5518 (feat(common): add ErrCurrencyNotAccepted #640's commit). go.sum changes only the pkg lines, GOWORK=off go build ./... passes, go mod verify passes, and go mod tidy is clean.
• Mutation probes each fail tests: dropping %w at any wrap site, %v at the retry wrap, and wrapping the sentinel into an HTTP 500. go test -race -count=1 ./... passes in providers/azure (with and without the workspace) and pkg. Lint is clean.
• Follow-ups, not blocking: an end-to-end errors.Is test per reservation service, and a savings plan negative test that reaches the currency check.

[claude-cc-libs]