[8주차] 나명준/[infra] Docker Compose & CI/CD#331
Open
Nanajun22 wants to merge 20 commits into
Hidden character warning
The head ref may contain hidden characters: "\ub098\uba85\uc900/8\uc8fc\ucc28"
Open
Conversation
vyfhfhd
reviewed
May 28, 2026
vyfhfhd
left a comment
There was a problem hiding this comment.
cd.yml 부분이 깔끔해서 많이 참고했습니다 수고하셨어요!
다만 배포 스크립트에서는 ${{ secrets.DOCKER_USERNAME }}/leets-test:latest 이미지를 pull 하고 있는데, docker-compose.yml에서는 nanajun/leets-test:latest로 하드코딩되어 있어 Docker 계정명이 변경되면 실제 pull 한 이미지와 compose에서 실행하는 이미지가 달라질 수 있을 것 같습니다!
KunHeeLee7
reviewed
May 28, 2026
KunHeeLee7
left a comment
There was a problem hiding this comment.
needs: test를 활용해 테스트 성공 이후에만 build가 진행되도록 구성한 점이 좋았고, 전체적인 CI 흐름도 깔끔하게 잘 작성하신 것 같습니다 👍
추가로 chmod +x gradlew를 넣어주면 환경에 따라 발생할 수 있는 실행 권한 문제까지 방지할 수 있어 더 안정적으로 동작할 것 같습니다! 수고하셨습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. 과제 요구사항 중 구현한 내용
2. 핵심 변경 사항
docker compose.yml
CI CD 파이프 라인
3. 실행 및 검증 결과
4. 완료 사항
5. 추가 사항
제출 체크리스트
{이름}/main브랜치다{이름}/{숫자}주차브랜치다Reviewer 참고