AutoGG and Method Refactor#20
Conversation
Added AutoGG and renamed the methods in the Spectator Squeak feature to better match its class name.
|
:3 |
|
Seems fine to me. Make the GG message configurable? |
Bumped version and added the ability to customize the autogg message, thank you kyrptconfig for making that so easy <3
|
Bumped version and added the ability to customize the autogg message, thank you kyrptconfig for making that so easy <3 |
|
Should AutoGG be disabled or enabled by default? |
|
I would think enabled. We dont really have the volume of people that use LCH that would make it something we should have disabled by default |
|
should be fine to have it enabled by default, its easy to change anyway, either via config folder or via mod menu |
|
LEMClientHelper usually isn't installed by people before they ever touch LEM. Having this feature enabled by default would throw people off just by having muscle memory to type it in themselves |
|
Yeah, at first i thought "Well no, it shouldnt be installed cause it could be spammy, or if we started having a ton of people install lch, it would flood chat every game" but figured most people who do install it are pretty into lem as is, so it wouldnt be that heavily used. |
added delay (in ticks) to autoggconfig, implemented a tick delay to the actual feature, and updated the mod menu integration to include it, along with translation key for the new setting
|
added a configurable delay (in ticks), and also people say gg after every game as it is, on top of that it can just be disabled for those who dont want it, and even most mentions of lch go ignored anyway so it likely wont come up too often. if anyone wants to implement a first launch ask for enabling autogg i think thats ok but i am not adding it myself, i can always just set the default state to disabled if people really care that much about it but i think having it enabled by default for now is fine. |
the previous iteration decremented the ticksUntilGG variable before checking for a value of 0, making the default delay of 0 never meet the requirement to play the message, this has now been fixed.
|
fixed the bug with message not sending on a delay of 0 |
|
I'll look into this more this weekend. I would like to consider having server utils notifying the clients the game was over to signal the GG rather than a sound event. |
|
That would be a pretty good idea, as i can see some modtools map somewhere made by some troll that spams the sound event to get everyone using LCH to spam chat / cause issues |
|
i'll see what i can do about that, i will just need a bit to look over serverutils |
|
It would likely need hooking into the datapack too. I don't think server utils even knows the game is over? |
|
probably the case, i dont think it'd be that difficult to add to the dp, i could figure something out |
5 participants
Added AutoGG and renamed the methods in the Spectator Squeak feature to better match its class name.