Skip to content

Added Damage Direction Indicator#21

Open
Awsome-Creeper9 wants to merge 3 commits into
Legacy-Edition-Minigames:1.20.4from
Awsome-Creeper9:1.20.4
Open

Added Damage Direction Indicator#21
Awsome-Creeper9 wants to merge 3 commits into
Legacy-Edition-Minigames:1.20.4from
Awsome-Creeper9:1.20.4

Conversation

@Awsome-Creeper9

Copy link
Copy Markdown

Added the Damage Direction Indicator that was in LCE Battle (the red square thing around the crosshair).

@TerraKaminari

Copy link
Copy Markdown

tasty mixin

@Awsome-Creeper9

Copy link
Copy Markdown
Author

Known issue: does nothing for non-directional damage sources

@kyrptonaught

Copy link
Copy Markdown
Member

Implementation looks good. Though we would have to consider if this gives an unfair advantage to LCH users over vanilla?

@Awsome-Creeper9

Copy link
Copy Markdown
Author

Technically it just uses the same system vanilla Minecraft uses for damage tilt angle, so in theory this info is already accessible in vanilla (though I get it can be hard to tell sometimes)

@ThatBooze

Copy link
Copy Markdown

Implementation looks good. Though we would have to consider if this gives an unfair advantage to LCH users over vanilla?

I think this is fair play because there's the existing 'Damage Tilt' option inside of Minecraft and the option to enable 'Subtitles'. This feature would help make the game more accessible by giving visual feedback to the player

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants