Added Damage Direction Indicator#21
Open
Awsome-Creeper9 wants to merge 3 commits into
Open
Conversation
|
tasty mixin |
Author
|
Known issue: does nothing for non-directional damage sources |
Member
|
Implementation looks good. Though we would have to consider if this gives an unfair advantage to LCH users over vanilla? |
Author
|
Technically it just uses the same system vanilla Minecraft uses for damage tilt angle, so in theory this info is already accessible in vanilla (though I get it can be hard to tell sometimes) |
I think this is fair play because there's the existing 'Damage Tilt' option inside of Minecraft and the option to enable 'Subtitles'. This feature would help make the game more accessible by giving visual feedback to the player |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the Damage Direction Indicator that was in LCE Battle (the red square thing around the crosshair).