Skip to content

Improve Success Message#7

Open
seanpdoyle wants to merge 1 commit into
LevelbossMike:masterfrom
seanpdoyle:improve-success-message
Open

Improve Success Message#7
seanpdoyle wants to merge 1 commit into
LevelbossMike:masterfrom
seanpdoyle:improve-success-message

Conversation

@seanpdoyle
Copy link
Copy Markdown

Provide the caller with a copy-pastable activation command

Provide the caller with a copy-pastable activation command
Comment thread lib/redis.js
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LevelbossMike this most likely won't work, since this.config.environment is a guessed variable, and most likely undefined.

What would be the best way to access the environment?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately you don't have access to the environment via the config object. this will be possible in the upcoming versions of ember-deploy with the deployment-pipeline and the new hooks-architecture.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could patch this in the configuration-reader of ember-cli-deploy and pass the environment there but this is kind of messy and will be fixed via the upcoming changes in ember-cli-deploy itself.

This would be a great addition to ember-deploy-redis. Thanks for catching this. I'll leave this open and ping you when ember-cli-deploy is ready.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks I'll keep my eyes peeled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants