libvncserver: restore AF_UNIX client hosts#715
Open
marcofortina wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore AF_UNIX client host handling for server-side Unix socket connections.
When a client connects through a Unix domain socket,
rfbNewTCPOrUDPClient()currently treats the accepted socket like a TCP socket. On IPv6-capable builds,getnameinfo()fails for AF_UNIX andcl->hostbecomes an empty string. This breaks consumers such as x11vnc that run access checks innewClientHook()before they can repair the host value themselves.Changes
getpeername()before using the address.cl->hostfromgetsockname().TCP_NODELAYonly to TCP clients, not AF_UNIX clients.newClientHook()with a non-empty host string.Validation
Tested with:
cmake -S . -B build-498-patch \ -DWITH_EXAMPLES=OFF \ -DWITH_TESTS=ON \ -DWITH_OPENSSL=OFF \ -DWITH_GNUTLS=OFF \ -DWITH_GCRYPT=OFF \ -DWITH_SDL=OFF \ -DWITH_GTK=OFF \ -DWITH_QT=OFF \ -DWITH_FFMPEG=OFF \ -DWITH_XCB=OFF \ -DWITH_LIBSSHTUNNEL=OFF \ -DWITH_SYSTEMD=OFF \ -DCMAKE_BUILD_TYPE=Debug cmake --build build-498-patch --parallel 1 ctest --test-dir build-498-patch --output-on-failureResult:
Notes
Closes #498.