libvncclient: add client-aware logging helpers#721
Open
marcofortina wants to merge 3 commits into
Open
Conversation
d501ff0 to
c40b111
Compare
learn-more
reviewed
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a non-breaking LibVNCClient logging path that can carry the
rfbClient *context to applications that want client-aware log output.
Preflight
rfbClientLog/rfbClientErrcallbacks.Changes
rfbClientLogandrfbClientErrcallbacks unchanged.rfbClientLogWithClientrfbClientErrWithClientrfbClientLogEx(rfbClient *client, ...)rfbClientErrEx(rfbClient *client, ...)rfbClient *in scope to use the new helpers, including:rfbclient.crfbClient *context, such as listen/socket utility helpers, OpenSSL global initialization helpers, and the publicPrintPixelFormat()compatibility entry point.Validation
git diff --checkctest --test-dir build-675-patch --output-on-failurectest --test-dir build-675-openssl --output-on-failurectest --test-dir build-675-sasl --output-on-failurecmake -DWITH_OPENSSL=OFF -DWITH_GNUTLS=ON -DWITH_GCRYPT=ON -DWITH_LIBVNCSERVER=OFF ..rfbClientLog/rfbClientErrcall sites are limited to helpers withoutrfbClient *context plus examples/tests.Result:
100% tests passed, 0 tests failed out of 5100% tests passed, 0 tests failed out of 5100% tests passed, 0 tests failed out of 5Notes
This intentionally avoids changing the existing
rfbClientLogProcABI/API. It gives applications a new opt-in path for client-aware logging while preserving the legacy global callbacks for existing users.Closes #675.