libvncclient: add framebuffer viewport mode#722
Open
marcofortina wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in LibVNCClient framebuffer viewport mode for applications that only
want to keep a sub-rectangle of the remote framebuffer locally instead of
allocating the full remote framebuffer.
Changes
rfbClientSetFrameBufferViewport(client, x, y, w, h).rfbClientClearFrameBufferViewport(client).rfbClientin remote framebuffer coordinates.viewport_w * viewport_hpixels in the default framebuffer allocator.client->frameBufferhas already been allocated, because the framebuffer size/stride has already been chosen.client_viewporttestcovering invalid viewport rejection, update rectangle setup, reduced framebuffer drawing/clipping, and post-allocation lifecycle guards.Validation
Recommended local validation before merge:
git diff --check rm -rf build-8-patch cmake -S . -B build-8-patch \ -DWITH_EXAMPLES=OFF \ -DWITH_TESTS=ON \ -DWITH_OPENSSL=OFF \ -DWITH_GNUTLS=OFF \ -DWITH_GCRYPT=OFF \ -DWITH_SDL=OFF \ -DWITH_GTK=OFF \ -DWITH_QT=OFF \ -DWITH_FFMPEG=OFF \ -DWITH_XCB=OFF \ -DWITH_LIBSSHTUNNEL=OFF \ -DWITH_SYSTEMD=OFF \ -DWITH_JPEG=OFF \ -DCMAKE_BUILD_TYPE=Debug cmake --build build-8-patch --parallel 1 ctest --test-dir build-8-patch --output-on-failureNotes
This feature is intentionally conservative. It is meant for applications that
use LibVNCClient's default framebuffer allocator and default drawing callbacks.
Applications that override drawing callbacks such as
GotBitmap,GotFillRector
GotCopyRectmust apply the same remote-to-local viewport mapping in theirown callbacks.
The viewport must be configured before
rfbClientInitialise()or before anyapplication-provided framebuffer allocation. Changing it after framebuffer
allocation is rejected to avoid making the local framebuffer size/stride
inconsistent with the requested update rectangle.
Closes #8.