httpd: fix crash in rfbHttpShutdownSockets when httpDir is NULL#723
Open
ivanxgb wants to merge 1 commit into
Open
httpd: fix crash in rfbHttpShutdownSockets when httpDir is NULL#723ivanxgb wants to merge 1 commit into
ivanxgb wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request resolves a crash (segmentation fault / access violation) that occurs in if no HTTP directory is configured () and no client has connected during the server's lifecycle (fixes #704).
Cause
In , the HTTP socket initialization returns early if is . Because of this, the mutexes of the file-static structure (, , ) are never initialized via .
However, during shutdown in , these mutexes are unconditionally locked, unlocked, and destroyed, leading to an immediate segmentation fault.
Fix
We introduced a file-static boolean flag in to track whether these client-related mutexes have been successfully initialized. The shutdown operations are now safely wrapped in a conditional check:
Verification & Testing
The fix has been compiled and verified inside a secure sandbox container on a Debian Bookworm VPS, utilizing the following minimal reproduction program: