Open
Conversation
…rker0 during unit tests
…ior with additional worker zero
…kers (with gen_on_worker defaulting to False) clear to resources. other temporary debug adjusts
…s this actually solve anything?
…ors, regarding the default presence of the zeroth worker. assistance from gemini/claude for fixing resource math in various tests.
…for self.zero_resource_workers.get breaks too many tests for the benefit
… zero-resource-worker. [0] shouldn't factor into the math for get_workers2assign2
… procs matched to GPUs we really ought to assign sims to those resource sets first. Only if no GPU rsets exist do we fallback to non-gpu sets, producing a correct wait upon allocation. Thanks Claude.
…n_on_worker_try_again
…kers for initializing resources
…tent gen is always available to receive gen work. so to prevent worker 0 from generating extra, set sim max. another way to prevent extra non-persistent gen calls is set gen_on_worker=True
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1703 +/- ##
============================================
+ Coverage 78.24% 92.84% +14.60%
============================================
Files 81 81
Lines 8227 8218 -9
Branches 1261 1259 -2
============================================
+ Hits 6437 7630 +1193
+ Misses 1556 387 -1169
+ Partials 234 201 -33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
gen_on_managerand replace withgen_on_worker. Remove docs mentions ofgen_on_manager.Remove
zero_resource_workers.Misc typing adjustments and fixes.
Various corresponding indexing fixes for the gen to get assigned GPUS/procs separately.
get_index_listneeded a tricky adjust. First element isNonesince worker 0's resources are handled separately.Adjustments to the tests. Some tests like the profile and splitcomm test are flakey without gen_on_worker.
Docs and tutorials updates.
Some forces-building adjusts for macOS compiling.
TODO: Undo overkill changes to test_GPU_gen_resources. Obviously hot-swapping hardware mid-loop shouldn't fix anythingAddresses #1426