Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Quick Start hub cards now end with opening localhost:3080 and registering, and the npm card lists the Node.js version LibreChat pins (24.16.0) instead of the stale v20.19+. The condensed Local Setup guide now gives the exact cd, .env copy, and first-run commands plus the first-account-is-admin note. Feedback: 1561174654356562005
Feedback: 1561325513748779132
690877c to
f9f4a9c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9f4a9c06f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| // The failure path points somewhere that exists. | ||
| const troubleshooting = body(page).getByRole('link', { | ||
| name: 'Docker guide troubleshooting section', |
There was a problem hiding this comment.
Check the handoff before leaving the setup page
Move the Your First Chat assertion before this click (or navigate back afterward). The click navigates from Local Setup to the Docker troubleshooting section, and the Docker guide independently contains a Your First Chat link, so the test still passes if the newly documented Step 4 handoff is later removed or given an incorrect URL.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 1300210: the handoff assertion now runs on Local Setup before the click into the Docker guide. f75f363 also matches the link exactly, because the footer's next-page card links to Your First Chat too and would have masked a missing Step 4 link. @Scenario:local-setup-gives-exact-run-commands passes in the End-to-end tests job on f75f363 (62/62).
📦 Next.js Bundle Analysis for librechat.aiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
📦 Next.js Bundle Analysis for librechat.aiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
📦 Next.js Bundle Analysis for librechat.aiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Summary
The Quick Start hub cards stopped at "start the app", so readers never learned to open
localhost:3080and register. The npm card also listed Node.js v20.19+, but LibreChat now pins 24.16.0 (.nvmrc, matching the npm guide). Step 3 of the condensed Local Setup guide said "navigate to the project directory" and "fill in any necessary values" without giving the commands. Separately, the "desktop installer" callout on the docs index covered Windows and Linux but not macOS.Hub card strings are hand-maintained, so all 14 locale dictionaries are updated. The MDX edits are English only and go through the usual translation workflow. Since main gained the Step 4 "Start Chatting" handoff to Your First Chat, this PR keeps that step and only makes Step 3 concrete.
Feedback addressed
1561174654356562005:/pt-BR/docs/quick_startcd,.envcopy (including the Windowscopyform) anddocker compose up -dcommands, what to expect on first launch, and a link to Docker troubleshooting. CheckedPORT=3080andALLOW_REGISTRATION=trueagainst upstream.env.example.1561325513748779132:/es/docsValidation
e2e/quick-start-install-steps.spec.ts, four scenarios: card steps in English, card steps in all 13 other locales, Local Setup command order plus the troubleshooting and First Chat links, and macOS in the docs callout. All four pass in the End-to-end tests job on this head (full suite 62 passed).npx eslint --max-warnings 0andprettier --checkon the changed TS files: passedpnpm typecheck: passednpx vitest run: 38 files, 436 tests passedNot changed
local/docker.mdxis unchanged. It is outside what either report asked about.