Skip to content

Library manual#42

Open
ouabache wants to merge 4 commits into
LibrePCB:masterfrom
ouabache:Library_Manual
Open

Library manual#42
ouabache wants to merge 4 commits into
LibrePCB:masterfrom
ouabache:Library_Manual

Conversation

@ouabache

Copy link
Copy Markdown

No description provided.

@ubruhin

ubruhin commented Dec 29, 2019

Copy link
Copy Markdown
Member

This adds a lot of useless files inside the Library_Manual directory (.editorconfig, .gitattributes, CONTRIBUTING.md, ...), could you please remove them? And could you maybe rebase the branch to master and get rid of the merge commit? IMHO it's very hard to understand the current commit history ;)

In addition, the new content will not appear in the hosted documentation since it is not included anywhere...

@ouabache

ouabache commented Dec 30, 2019 via email

Copy link
Copy Markdown
Author

@ubruhin

ubruhin commented Jan 6, 2020

Copy link
Copy Markdown
Member

Done

Where? 😁 There was no push on this branch ;)

@ouabache

ouabache commented Jan 6, 2020 via email

Copy link
Copy Markdown
Author

@rnestler

rnestler commented Jun 3, 2020

Copy link
Copy Markdown
Member

I show it in my LibrePCB repo under branch library_manual

The branch name for this PR is called Library_Manual, maybe that's the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants