feat: policy signature flow by vitormattos · Pull Request #7366 · LibreSign/libresign

vitormattos · 2026-04-01T23:19:09Z

No description provided.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

…al default Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Verify that: - Policies nav item appears for a group subadmin when the instance admin has created a group-scoped rule with allowChildOverride:true. - The policy card is visible inside the workbench and the Configure button opens the setting dialog with an enabled Create rule button. - Clicking Create rule opens the scope-selector modal (create policy dialog). - After the admin removes the group rule, a page reload hides the nav item. All admin operations run via OCS API (no admin browser session), keeping the test fast. A single group-admin browser session covers both phases. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

…ibility Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

github-project-automation bot added this to Roadmap Apr 1, 2026

github-project-automation bot moved this to 0. Needs triage in Roadmap Apr 1, 2026

vitormattos force-pushed the feat/policy-signature-flow-phase1-groundwork branch 2 times, most recently from d422bd0 to da50ad0 Compare April 7, 2026 15:51

vitormattos changed the title ~~feat: policy signature flow phase1 groundwork~~ feat: policy signature flow Apr 7, 2026

vitormattos force-pushed the feat/policy-signature-flow-phase1-groundwork branch 2 times, most recently from 6146425 to 6e4ab74 Compare April 9, 2026 14:47

vitormattos added 23 commits April 11, 2026 15:56

fix(policy-workbench): pass editor context props to policy editor

07eccfd

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(signature-flow): block no-op default option on instance create

c702e58

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(policy-workbench): require dirty draft before saving rules

6cdb1b8

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(policy-workbench): align instance row and create gating with glob…

aa18803

…al default Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(signature-flow): cover disabled default option in instance create

a249fb8

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(policy-workbench): require system create value change before save

f365094

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(policy-workbench): show remove and instance create actions in UI

ea00296

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(e2e): reflect baseline reset behavior without explicit instance row

7b9e50c

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(migration): migrate docmdp_level from string to int type

498e21c

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(policy-workbench): isolate override counters per setting card

10e75d1

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(policy-workbench): prevent cross-card rule count leakage

95fbec4

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(ui): simplify policy workbench terminology

10bced0

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(ui): rewrite setting copy for clarity

230d127

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(ui): rename signature flow default label

effd71a

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(ui): align signing order definition wording

0f16113

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(ui): remove policy term from identify factors

e715930

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(ui): replace override badge label

9f94dee

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(ui): simplify legacy signing settings copy

e6c461f

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(ui): update signature flow label assertions

788e2c4

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(ui): update summary wording expectations

6a9a235

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(ui): adapt settings workbench terminology checks

614fff8

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(migration): split Version18001 into scoped helpers

534f6ee

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(docmdp): enforce typed config read only

8d9b548

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

vitormattos added 7 commits April 11, 2026 15:56

test(settings): hide policies menu when no editable policies

8a2210c

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(settings): gate policies menu by editable policies

820e5aa

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(settings): require delegated rules for policies menu

26e38e8

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(settings): hide policies menu without delegated policies

9fed5c0

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(settings): react to delegated policies menu state

eb92187

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(settings): show policies menu from reactive policy store

a7300a6

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

vitormattos force-pushed the feat/policy-signature-flow-phase1-groundwork branch from 6758fbe to 13b9c07 Compare April 11, 2026 18:56

vitormattos added 22 commits April 11, 2026 16:09

test(settings): hide policies entry when delegated rules are read-only

80ffc8d

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(e2e): assert policies menu visibility by editability

837af40

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(settings): require editable delegated policy for menu

4b473e8

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(folder): fallback to appdata when user home is unavailable

5d0dd53

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(policy): tolerate legacy appconfig type conflicts

a4216f1

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(behat): use policies API for sequential flow setup

8674763

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(behat): configure footer via policy endpoint

cc193e0

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(playwright): target signing-order card button directly

c52e189

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(unit): avoid null delete in file-not-found scenario

ddf6b63

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(router): gate policies route by management capability

3e13f6c

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(router): cover policies access guard redirects

b912db2

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

revert(router): remove policies route guard, nav already controls vis…

3e18618

…ibility Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

revert(test/router): remove tests for policies access guard

3385308

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(settings): hide preferences when no personal override is allowed

1bc1e94

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(settings): cover preferences menu visibility

0124315

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(policy): cover actor capabilities in context factory

8f3540f

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(policy): propagate actor capabilities in context factory

392367f

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(policy): cover resolver editability semantics

d5e8a49

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(policy): decouple resolver editability from overrides

3dab7c1

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(controller): cover user policy authorization

444610a

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(controller): guard target user policy endpoints

6a3c483

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(policy): align service expectations with actor capabilities

02a50f1

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: policy signature flow#7366

feat: policy signature flow#7366
vitormattos wants to merge 614 commits intomainfrom
feat/policy-signature-flow-phase1-groundwork

vitormattos commented Apr 1, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

vitormattos commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vitormattos commented Apr 1, 2026 •

edited

Loading