chore: remove noisy balance alerts and the dead Telegram integration#198
Merged
Conversation
Remove the BalanceAlertService cron and its threshold config, which posted frequent LOW/HIGH wallet balance alerts to Telegram. The thresholds rarely cleared, so the alerts were constant noise rather than actionable signals. Also drop the now-unused TelegramModule import from MonitoringModule (BalanceAlertService was its only consumer).
With the balance alerts gone, TelegramService had no remaining callers and TelegramModule was imported nowhere. Remove the integration module, the service, and the now-dead telegram config block (TELEGRAM_BOT_TOKEN / TELEGRAM_CHAT_ID are no longer read).
Danswar
force-pushed
the
chore/remove-balance-alerts
branch
from
b30c9a6 to
b84bc09
Compare
davidleomay
approved these changes
Jun 9, 2026
Collaborator
There was a problem hiding this comment.
LGTM from a technical perspective — clean removal, no dangling references, imports/modules all check out, and the BoltzModule retention is correct.
That said, @TaprootFreak might want to weigh in on whether this alerting logic is really not needed anymore.
TaprootFreak
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the noisy balance-threshold Telegram alerts (
ldsMonitoringBotLOW/HIGH messages) and the now-orphaned Telegram integration behind them.Commit 1 — remove the balance alerts
BalanceAlertService— the@Cron(EVERY_5_MINUTES)posting LOW/HIGH wallet-balance alerts to Telegram.balance-thresholds.config.ts— threshold list, used only by that service.TelegramModuleimport inMonitoringModule.Why: the LOW thresholds (e.g. 1000 USDT on chains holding ~0) effectively never cleared, so the same alerts fired every 5 minutes — noise, not signal.
Commit 2 — remove the dead Telegram integration
With the alerts gone,
TelegramServicehad zero callers andTelegramModulewas imported nowhere. Removed:src/integration/telegram/telegram.module.tssrc/integration/telegram/services/telegram.service.tstelegramconfig block inconfig.tsDeploy note:
TELEGRAM_BOT_TOKEN/TELEGRAM_CHAT_IDare no longer read — they can be dropped from deploy env/secrets.Kept intact
BoltzModulestays (still used byMonitoringEvmService); the rest of the monitoring subdomain is untouched. Repo-wide grep fortelegraminsrc/returns nothing after this change.6 files changed, 226 deletions.
Infra companion PR: DFXServer/server#361 — removes the now-unused
TELEGRAM_BOT_TOKEN/TELEGRAM_CHAT_IDfrom the LDS.envtemplates.