Repository navigation
fix(release): roll the release forward past an unverifiable v0.17.6 tag - #21
Closed
LilMGenius wants to merge 1 commit into
Closed
LilMGenius wants to merge 1 commit into
LilMGenius wants to merge 1 commit into
Conversation
- v0.17.6 carried its signature glued to the last line of its message, so git could not verify it and the release workflow would have cut the install command from the notes; 0.17.7 ships the same change under a clean tag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #22, which deletes and re-cuts the broken tag at the same version instead of moving the version on.
The v0.17.6 tag could not be verified: its message ended without a newline, so the signature was appended to its last line.
Failing input:
git tag -v v0.17.6.Cause: the tag message file lacked a trailing newline, so
git tag -s -Fglued the signature onto the install line.Evidence
git tag -v v0.17.6Fix and scope
This bumped
package.jsonandpackage-lock.jsonto 0.17.7 so the frontmatter gate from #20 would ship under a clean signed tag, leaving the defective tag in place. Closed unmerged in favour of #22.