perf: compute standings tiebreaker values once and fix Buchholz complexity

lua/wikis/commons/Standings/Parser.lua

@@ -146,9 +146,10 @@ function StandingsParser.calculateTiebreakerValues(opponentsInRound, tiebreakerI
 			return
 		end
 		Array.forEach(opponentsInRound, function(opponent)
+			local value = tiebreaker:valueOf(opponentsInRound, opponent)
 			opponent.extradata.tiebreakerValues[tiebreakerId] = {
-				value = tiebreaker:valueOf(opponentsInRound, opponent),
-				display = tiebreaker:display(opponentsInRound, opponent),
+				value = value,
+				display = tiebreaker:display(opponentsInRound, opponent, value),
 			}
 		end)
 	end)

lua/wikis/commons/Standings/Tiebreaker/Buchholz.lua

@@ -9,6 +9,7 @@ local Lua = require('Module:Lua')
 
 local Array = Lua.import('Module:Array')
 local Class = Lua.import('Module:Class')
+local FnUtil = Lua.import('Module:FnUtil')
 
 local Opponent = Lua.import('Module:Opponent/Custom')
 
@@ -17,23 +18,58 @@ local TiebreakerInterface = Lua.import('Module:Standings/Tiebreaker/Interface')
 ---@class TiebreakerBuchholz : StandingsTiebreaker
 local TiebreakerBuchholz = Class.new(TiebreakerInterface)
 
----@param state TiebreakerOpponent[]
+---Build a set of enemy names for an opponent, memoized per opponent entry table.
+---Falls back to Opponent.same for renamed-team detection and aliases the result.
 ---@param opponent TiebreakerOpponent
----@return integer
-function TiebreakerBuchholz:valueOf(state, opponent)
-	local enemies = Array.flatMap(opponent.matches, function(match)
+---@return table<string, true>
+local getEnemyNames = FnUtil.memoize(function(opponent)
+	local ownName = Opponent.toName(opponent.opponent)
+	local enemyNames = {}
+	Array.forEach(opponent.matches, function(match)
 		if not match.finished then
-			return {}
+			return
 		end
-		return Array.filter(match.opponents, function (opp)
-			return not Opponent.same(opp, opponent.opponent)
+		Array.forEach(match.opponents, function(matchOpponent)
+			local name = Opponent.toName(matchOpponent)
+			-- Skip self: by name, or by Opponent.same for renamed-team edge cases
+			if name == ownName then
+				return
+			end
+			if matchOpponent.type == 'team' and Opponent.same(matchOpponent, opponent.opponent) then
+				return
+			end
+			enemyNames[name] = true
 		end)
 	end)
+	return enemyNames
+end)
+
+---@param state TiebreakerOpponent[]
+---@param opponent TiebreakerOpponent
+---@return integer
+function TiebreakerBuchholz:valueOf(state, opponent)
+	local enemyNames = getEnemyNames(opponent)
 
 	return Array.reduce(state, function(score, groupMember)
-		local isEnemy = Array.any(enemies, function(enemy)
-			return Opponent.same(enemy, groupMember.opponent)
-		end)
+		local memberName = Opponent.toName(groupMember.opponent)
+		local isEnemy = enemyNames[memberName]
+
+		-- Fallback for renamed teams: scan match opponents with Opponent.same
+		if not isEnemy and groupMember.opponent.type == 'team' then
+			local found = Array.any(opponent.matches, function(match)
+				if not match.finished then
+					return false
+				end
+				return Array.any(match.opponents, function(matchOpponent)
+					return Opponent.same(matchOpponent, groupMember.opponent)
+				end)
+			end)
+			if found then
+				-- Alias so this cost is only paid once per group member
+				enemyNames[memberName] = true
+				isEnemy = true
+			end
+		end
 
 		if not isEnemy then
 			return score

lua/wikis/commons/Standings/Tiebreaker/Game/Diff.lua

@@ -30,8 +30,9 @@ end
 
 ---@param state TiebreakerOpponent[]
 ---@param opponent TiebreakerOpponent
+---@param value integer?
 ---@return string
-function TiebreakerGameDiff:display(state, opponent)
+function TiebreakerGameDiff:display(state, opponent, value)
 	local games = TiebreakerGameUtil.getGames(opponent)
 	return games.w .. ' - ' .. games.l
 end

lua/wikis/commons/Standings/Tiebreaker/Game/Rounds/Diff.lua

@@ -30,8 +30,9 @@ end
 
 ---@param state TiebreakerOpponent[]
 ---@param opponent TiebreakerOpponent
+---@param value integer?
 ---@return string
-function TiebreakerRoundDiff:display(state, opponent)
+function TiebreakerRoundDiff:display(state, opponent, value)
 	local rounds = TiebreakerRoundUtil.getRounds(opponent)
 	return rounds.w .. ' - ' .. rounds.l
 end

lua/wikis/commons/Standings/Tiebreaker/Game/WinRate.lua

@@ -31,13 +31,14 @@ end
 
 ---@param state TiebreakerOpponent[]
 ---@param opponent TiebreakerOpponent
+---@param value integer?
 ---@return string
-function TiebreakerGameWinRate:display(state, opponent)
+function TiebreakerGameWinRate:display(state, opponent, value)
 	local games = TiebreakerGameUtil.getGames(opponent)
 	if games == 0 then
 		return '-'
 	end
-	return MathUtil.formatPercentage(self:valueOf(state, opponent), 2)
+	return MathUtil.formatPercentage(value ~= nil and value or self:valueOf(state, opponent), 2)
 end
 
 return TiebreakerGameWinRate

lua/wikis/commons/Standings/Tiebreaker/Interface.lua

@@ -36,9 +36,13 @@ end
 
 ---@param state TiebreakerOpponent[]
 ---@param opponent TiebreakerOpponent
+---@param value integer?
 ---@return string
-function StandingsTiebreaker:display(state, opponent)
-	return tostring(self:valueOf(state, opponent))
+function StandingsTiebreaker:display(state, opponent, value)
+	if value == nil then
+		value = self:valueOf(state, opponent)
+	end
+	return tostring(value)
 end
 
 ---@return 'full'|'ml'|'h2h'

lua/wikis/commons/Standings/Tiebreaker/Match/Diff.lua

@@ -28,8 +28,9 @@ end
 
 ---@param state TiebreakerOpponent[]
 ---@param opponent TiebreakerOpponent
+---@param value integer?
 ---@return string
-function TiebreakerMatchDiff:display(state, opponent)
+function TiebreakerMatchDiff:display(state, opponent, value)
 	return opponent.match.w .. ' - ' .. opponent.match.l
 end
 

lua/wikis/commons/Standings/Tiebreaker/Match/WinRate.lua

@@ -30,9 +30,10 @@ end
 
 ---@param state TiebreakerOpponent[]
 ---@param opponent TiebreakerOpponent
+---@param value integer?
 ---@return string
-function TiebreakerMatchWinRate:display(state, opponent)
-	return MathUtil.formatPercentage(self:valueOf(state, opponent), 2)
+function TiebreakerMatchWinRate:display(state, opponent, value)
+	return MathUtil.formatPercentage(value ~= nil and value or self:valueOf(state, opponent), 2)
 end
 
 return TiebreakerMatchWinRate