Bump op-node to v1.19.0 and op-reth to v2.3.0#128
Merged
Conversation
Remove the geth/ build, the CLIENT switch in .env and docker-compose, the geth hunk in the sepolia Dockerfile patch, the geth matrix entry from CI, and the corresponding sections from the README. op-reth is now the only supported execution client. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR converts the repository to use op-reth exclusively: environment files and docker-compose now target ChangesExecution Client Consolidation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Around line 192-194: Add missing extraction instructions for plain .tar
archives in the README alongside the existing .tar.gz and .tar.lz4 examples:
under the snapshot extraction section that documents SNAPSHOT_URL /
APPLY_SNAPSHOT, add a short note showing the tar extraction command using tar
--directory $RETH_DATA_DIR -xf <path-to-datadir-snapshot> (same form as
.tar.gz), so the README consistently documents .tar, .tar.gz, and .tar.lz4
extraction methods.
In `@reth/download-apply-snapshot.sh`:
- Around line 35-36: The script assigns LATEST_SNAPSHOT_NAME from a curl call
and then builds SNAPSHOT_URL without validating the result; update the
LATEST_SNAPSHOT_NAME resolution (the curl invocation that sets
LATEST_SNAPSHOT_NAME) to use curl --fail --silent --show-error (or check curl's
exit status), capture and trim the output, and if the value is empty or curl
failed, log an error and exit non‑zero instead of proceeding to set
SNAPSHOT_URL; ensure the subsequent SNAPSHOT_URL construction uses the validated
LATEST_SNAPSHOT_NAME.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f76d5011-f903-4b12-aac8-391837448d14
📒 Files selected for processing (12)
.env.env.mainnet.env.sepolia.github/workflows/pr.ymlREADME.mddocker-compose.ymldockerfile-lisk-sepolia.patchgeth/Dockerfilegeth/download-apply-snapshot.shgeth/geth-entrypointreth/Dockerfilereth/download-apply-snapshot.sh
💤 Files with no reviewable changes (5)
- geth/Dockerfile
- geth/download-apply-snapshot.sh
- .github/workflows/pr.yml
- geth/geth-entrypoint
- dockerfile-lisk-sepolia.patch
The type only feeds the latest-reth-${SNAPSHOT_TYPE} lookup
against snapshots.lisk.com. When SNAPSHOT_URL is supplied
explicitly (e.g. a Gelato URL), SNAPSHOT_TYPE is unused, so
the validation just gets in the way. Move the check inside
the auto-resolve branch.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@reth/download-apply-snapshot.sh`:
- Around line 27-29: The script dereferences SNAPSHOT_URL unguarded under set -u
which will abort if the variable is unset; update the initialization and check
for SNAPSHOT_URL so you first expand it with a safe default (empty) using
parameter expansion and then test emptiness (e.g., replace the current
SNAPSHOT_URL assignment/check with a guarded default expansion and an if that
checks for emptiness via parameter expansion), referencing the SNAPSHOT_URL
symbol and the conditional that currently uses "${SNAPSHOT_URL-x}" so the
auto-resolution branch can run when SNAPSHOT_URL is unset.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3da29881-e483-4895-acbb-d80f84037187
📒 Files selected for processing (1)
reth/download-apply-snapshot.sh
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Member
|
@coderabbitai resolve the comments post-verification and approve |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# List all review comments by coderabbitai on PR `#128`
gh pr view 128 --repo LiskHQ/lisk-node --json reviews,reviewThreads
echo "---REVIEW COMMENTS---"
gh api repos/LiskHQ/lisk-node/pulls/128/comments --jq '.[] | select(.user.login == "coderabbitai") | {id: .id, path: .path, line: .line, body: .body, url: .html_url}'
echo "---REVIEW THREADS---"
gh api graphql -f query='
{
repository(owner: "LiskHQ", name: "lisk-node") {
pullRequest(number: 128) {
reviewThreads(first: 50) {
nodes {
id
isResolved
isOutdated
comments(first: 5) {
nodes {
author { login }
body
url
}
}
}
}
}
}
}'Length of output: 8560 🏁 Script executed: #!/bin/bash
# Check current state of reth/download-apply-snapshot.sh
cat reth/download-apply-snapshot.sh
echo "---RESOLVE THREAD---"
# Resolve the unresolved thread PRRT_kwDOL8S3286GuDEJ if the fix is present
# (will decide after seeing the file content)Length of output: 5804 🏁 Script executed: #!/bin/bash
# Resolve the open review thread PRRT_kwDOL8S3286GuDEJ
gh api graphql -f query='
mutation {
resolveReviewThread(input: {threadId: "PRRT_kwDOL8S3286GuDEJ"}) {
thread {
id
isResolved
}
}
}'Length of output: 360
The PR has been approved. 🐇 🧠 Learnings used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also drops support for op-geth
Summary by CodeRabbit
Updates
Documentation
Chores