Add OP_RETH_TRUSTED_PEERS for static EL peers#130
Conversation
Document the four Lisk-operated static EL enodes per network as opt-in trusted peers under the snap-sync block, and wire OP_RETH_TRUSTED_PEERS into --trusted-peers in the reth entrypoint. Also replaces the Sepolia bootnode placeholder with a real enode. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds OP_RETH_TRUSTED_PEERS to environment files and wires it in reth-entrypoint to pass --trusted-peers to op-reth node when set. ChangesReth Trusted Peer Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@reth/reth-entrypoint`:
- Around line 35-37: The current check uses [ "${OP_RETH_TRUSTED_PEERS+x}" = x ]
which is true for set-but-empty variables and causes ADDITIONAL_ARGS to get an
empty --trusted-peers=; update the guard to ensure OP_RETH_TRUSTED_PEERS is both
set and non-empty before appending to ADDITIONAL_ARGS (i.e., test the variable
value itself rather than only set-ness). Locate the block in reth-entrypoint
that references OP_RETH_TRUSTED_PEERS and ADDITIONAL_ARGS and change the
conditional to verify a non-empty value (so you only add
--trusted-peers=$OP_RETH_TRUSTED_PEERS when OP_RETH_TRUSTED_PEERS is not empty);
also confirm the comma-separated enode list format is acceptable for op-reth
--trusted-peers.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8ec57261-3964-4a9e-9099-b0c4fd15531e
📒 Files selected for processing (3)
.env.mainnet.env.sepoliareth/reth-entrypoint
Avoid emitting a bare --trusted-peers= when the env var is set but empty. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Summary
OP_RETH_TRUSTED_PEERSunder the snap-sync block. These peers are also discoverable via the standard bootnode.OP_RETH_TRUSTED_PEERSinto--trusted-peersinreth/reth-entrypointso the env var takes effect when uncommented.OP_RETH_BOOTNODESplaceholder with a real enode.Test plan
OP_RETH_TRUSTED_PEERSuncommented; confirm--trusted-peers=...appears in the launch args and the node connects to each enode.OP_RETH_TRUSTED_PEERSleft commented; confirm behavior is unchanged from before this PR.OP_RETH_BOOTNODES: confirm discovery stays enabled and both flags coexist.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation
Chores