Skip to content

Add OP_RETH_TRUSTED_PEERS for static EL peers#130

Merged
sameersubudhi merged 3 commits into
mainfrom
feat/add-trusted-el-peers
Jun 11, 2026
Merged

Add OP_RETH_TRUSTED_PEERS for static EL peers#130
sameersubudhi merged 3 commits into
mainfrom
feat/add-trusted-el-peers

Conversation

@sameersubudhi

@sameersubudhi sameersubudhi commented Jun 11, 2026

Copy link
Copy Markdown
Member

Summary

  • Document the four Lisk-operated static EL enodes per network (mainnet + sepolia) as opt-in OP_RETH_TRUSTED_PEERS under the snap-sync block. These peers are also discoverable via the standard bootnode.
  • Wire OP_RETH_TRUSTED_PEERS into --trusted-peers in reth/reth-entrypoint so the env var takes effect when uncommented.
  • Replace the Sepolia OP_RETH_BOOTNODES placeholder with a real enode.

Test plan

  • Start op-reth with OP_RETH_TRUSTED_PEERS uncommented; confirm --trusted-peers=... appears in the launch args and the node connects to each enode.
  • Start op-reth with OP_RETH_TRUSTED_PEERS left commented; confirm behavior is unchanged from before this PR.
  • Combined with OP_RETH_BOOTNODES: confirm discovery stays enabled and both flags coexist.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Support for configuring trusted peers for Reth execution nodes (mainnet & Sepolia), enabling nodes to treat specified peers as trusted.
  • Documentation

    • Added commented example environment entries to guide configuring bootnodes and trusted peers on Sepolia.
  • Chores

    • Removed the scheduled fork-sync CI workflow.

Document the four Lisk-operated static EL enodes per network as opt-in
trusted peers under the snap-sync block, and wire OP_RETH_TRUSTED_PEERS
into --trusted-peers in the reth entrypoint. Also replaces the Sepolia
bootnode placeholder with a real enode.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 763abc64-7aea-44b7-a660-cfa526d56452

📥 Commits

Reviewing files that changed from the base of the PR and between 2389d91 and f46b528.

📒 Files selected for processing (1)
  • reth/reth-entrypoint
🚧 Files skipped from review as they are similar to previous changes (1)
  • reth/reth-entrypoint

📝 Walkthrough

Walkthrough

Adds OP_RETH_TRUSTED_PEERS to environment files and wires it in reth-entrypoint to pass --trusted-peers to op-reth node when set.

Changes

Reth Trusted Peer Configuration

Layer / File(s) Summary
Trusted peers environment configuration
.env.mainnet, .env.sepolia
.env.mainnet adds OP_RETH_TRUSTED_PEERS with enode URLs; .env.sepolia replaces TODOs with commented example OP_RETH_BOOTNODES and OP_RETH_TRUSTED_PEERS entries.
Entrypoint trusted peer startup argument
reth/reth-entrypoint
Adds conditional logic to read OP_RETH_TRUSTED_PEERS and append --trusted-peers=... to ADDITIONAL_ARGS passed to op-reth node.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • LiskHQ/lisk-node#126: Adds --bootnodes configuration via OP_RETH_BOOTNODES to the same entrypoint startup argument logic.

Suggested reviewers

  • Nazgolze
  • shuse2

Poem

🐰 I nibble env lines, tidy and neat,
Enode strings curled up like a treat.
Entrypoint listens, arguments leap,
Trusted peers gather, connections keep.
Hop—startup hums, the network sleeps sweet.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description deviates from the template, lacking the standard 'What was the problem?', 'How was it solved?', and 'How was it tested?' sections, though it provides clear summary, test plan, and implementation details. Restructure the description to follow the template: include 'What was the problem?' with issue reference, 'How was it solved?' with technical details, and 'How was it tested?' with test steps.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding OP_RETH_TRUSTED_PEERS support for static execution-layer peers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/add-trusted-el-peers

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@sameersubudhi sameersubudhi self-assigned this Jun 11, 2026
@sameersubudhi sameersubudhi requested a review from Nazgolze June 11, 2026 12:49

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@reth/reth-entrypoint`:
- Around line 35-37: The current check uses [ "${OP_RETH_TRUSTED_PEERS+x}" = x ]
which is true for set-but-empty variables and causes ADDITIONAL_ARGS to get an
empty --trusted-peers=; update the guard to ensure OP_RETH_TRUSTED_PEERS is both
set and non-empty before appending to ADDITIONAL_ARGS (i.e., test the variable
value itself rather than only set-ness). Locate the block in reth-entrypoint
that references OP_RETH_TRUSTED_PEERS and ADDITIONAL_ARGS and change the
conditional to verify a non-empty value (so you only add
--trusted-peers=$OP_RETH_TRUSTED_PEERS when OP_RETH_TRUSTED_PEERS is not empty);
also confirm the comma-separated enode list format is acceptable for op-reth
--trusted-peers.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8ec57261-3964-4a9e-9099-b0c4fd15531e

📥 Commits

Reviewing files that changed from the base of the PR and between 0f93d73 and 71c5d39.

📒 Files selected for processing (3)
  • .env.mainnet
  • .env.sepolia
  • reth/reth-entrypoint

Comment thread reth/reth-entrypoint Outdated
@sameersubudhi sameersubudhi enabled auto-merge (squash) June 11, 2026 12:56
Avoid emitting a bare --trusted-peers= when the env var is set but empty.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@sameersubudhi sameersubudhi mentioned this pull request Jun 11, 2026
@sameersubudhi sameersubudhi merged commit 6c84beb into main Jun 11, 2026
3 checks passed
@sameersubudhi sameersubudhi deleted the feat/add-trusted-el-peers branch June 11, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants