Add option to leave files where they are while importing library by T4g1 · Pull Request #503 · Listenarrs/Listenarr

T4g1 · 2026-04-09T12:03:50Z

Summary

Fix [Feature Request] option for keep local files while library import from root folder #494

Changes

Added

Ability to add root folders while selecting the root folder from which we want to import files
Ability to leave files in place when importing library
Ability to set the desired monitoring for audiobooks added through library importation

Testing

Check that the import does not change anything in the files when it is not asked to modify them

Notes

Next steps

[Feature Request] Allow to rename files to match the configured patterns #504 : It should be possible to process the imported files to rename them using the pattern defined in the settings. Some tests for that should be added too (see InteractiveManualImport_DontMoveAnything_DontRenameAnything)

… on files and set monitoring

therobbiedavis

Solid job! Thank you! Just a few changes and a request to please update the changelog!

therobbiedavis · 2026-04-14T01:32:23Z

listenarr.api/Controllers/ManualImportController.cs

+
+            foreach (var item in orderedItems)
+            {
+                var fileCount = orderedItems.Select(f => f.MatchedAudiobookId).Count();


This will count every item in the batch regardless of audiobook. Example: if you import 1 file for Book A and 1 file for Book B, both files see fileCount = 2 and are treated as multi-file imports, causing wrong naming.

fe/src/views/library/LibraryImportView.vue

therobbiedavis · 2026-04-14T02:20:06Z

listenarr.api/Services/ImportService.cs

        }
    }
+
+    public async Task PerformActionOn(Listenarr.Api.Services.FileMover.FileAction action, string source, string? destination = null, HashSet<string>? usedDestinations = null)


why not use usedDestinations? It's used for collision detection in the filemover.

therobbiedavis · 2026-04-14T02:23:03Z

listenarr.api/Services/IFileMover.cs

+        /// <param name="action">What we want to do with the file</param>
+        /// <param name="source">File</param>
+        /// <param name="destination">Optional destination of the action</param>
+        /// <param name="usedDestinations">To remove probably</param>


If we're removing then lets refactor and remove, otherwise lets update this description.

therobbiedavis · 2026-04-14T02:25:39Z

listenarr.domain/Models/Audiobook.cs

+        public string? BasePath {
+            get
+            {
+                return FileUtils.NormalizeStoredPath(field);


Lets instead normalize on the setter so reads are free

I would agree but what about values already in DB then ? Are we sure all values are currently normalized already ?

Yes, so let's include a one-time normalization migration with this to normalize existing BasePaths

I'm gonna need some pointers on how to achieve that, afaik, migration cannot be used to run arbitrary C# methods on the database and the logic of NormalizeStoredPath seems really complex to translate to SQL

Generate a migration like so:
dotnet ef migrations add NormalizeStoredPaths --project listenarr.infrastructure --startup-project listenarr.api

then add the following to the generated Up() in the migration:

migrationBuilder.Sql(@" UPDATE Audiobooks SET BasePath = RTRIM(TRIM(BasePath), '/\') WHERE BasePath IS NOT NULL AND BasePath != RTRIM(TRIM(BasePath), '/\'); UPDATE ApplicationSettings SET OutputPath = RTRIM(TRIM(OutputPath), '/\') WHERE OutputPath != RTRIM(TRIM(OutputPath), '/\'); ");

therobbiedavis · 2026-04-14T02:26:06Z

listenarr.domain/Models/Configuration.cs

+        {
+            get 
+            {
+                return FileUtils.NormalizeStoredPath(field);


same here, normalize on the setter

let's include a one-time normalization migration with this to normalize existing OutputPaths, then normalize the setter

therobbiedavis · 2026-04-14T02:36:22Z

fe/src/stores/rootFolders.ts


-  return { folders, loading, defaultFolder, load, create, update, remove }
+  function getLast() {
+    return folders.value.at(-1);


this assumes two people are not creating folders at the same time. We might want RootFolderFormModal to emit the saved entity's ID and resolve it directly.

I know this probably isn't a valid use-case, but also I've learned long ago not to assume how a user will use your software.

T4g1 · 2026-04-14T12:12:13Z

@therobbiedavis Thanks! I did a pass on your reviews, can you check again to see if we are aligned ?

therobbiedavis

@T4g1 Added a couple comments on the existing issues, outside of these it lgtm!

therobbiedavis · 2026-04-14T18:16:18Z

listenarr.domain/Models/Audiobook.cs

+        public string? BasePath {
+            get
+            {
+                return FileUtils.NormalizeStoredPath(field);


Yes, so let's include a one-time normalization migration with this to normalize existing BasePaths

therobbiedavis · 2026-04-14T18:16:58Z

listenarr.domain/Models/Configuration.cs

+        {
+            get 
+            {
+                return FileUtils.NormalizeStoredPath(field);


let's include a one-time normalization migration with this to normalize existing OutputPaths, then normalize the setter

therobbiedavis · 2026-04-14T18:19:49Z

CHANGELOG.md

-
-### Changed
- **Reduced redundancy for the manual import modal:** Small improvement that make it easier to add or edit import fields.
+## [0.2.66] - ?


Changelog needs to be updated from canary or rebased, then your changes would be under
## [Unreleased]
at the top. We will update this with a version and date before release.

T4g1 marked this pull request as ready for review April 10, 2026 11:56

T4g1 mentioned this pull request Apr 10, 2026

[Feature Request] Allow to rename files to match the configured patterns #504

Open

T4g1 force-pushed the fix/494-library-safe-imports branch from df07abd to 19eed3f Compare April 10, 2026 12:50

Import library: Create root folders on the fly, import without impact…

b5cf323

… on files and set monitoring

T4g1 force-pushed the fix/494-library-safe-imports branch from 2024229 to b5cf323 Compare April 10, 2026 12:56

therobbiedavis requested changes Apr 14, 2026

View reviewed changes

Review round 1

eed6258

T4g1 requested a review from therobbiedavis April 14, 2026 12:10

therobbiedavis requested changes Apr 14, 2026

View reviewed changes

Merge branch 'canary' into fix/494-library-safe-imports

8d754d2

Uh oh!

Conversation

T4g1 commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Added

Testing

Notes

Next steps

Uh oh!

therobbiedavis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

T4g1 commented Apr 14, 2026

Uh oh!

therobbiedavis left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

T4g1 commented Apr 9, 2026 •

edited

Loading

therobbiedavis left a comment •

edited

Loading