Refactor DownloadClientCategoryFilter as a proper OOP class#505
Open
T4g1 wants to merge 1 commit intoListenarrs:canaryfrom
Open
Refactor DownloadClientCategoryFilter as a proper OOP class#505T4g1 wants to merge 1 commit intoListenarrs:canaryfrom
T4g1 wants to merge 1 commit intoListenarrs:canaryfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I'm still trying to make sense of some parts of the code, while doing that I figured this could help to reduce code complexity to start refactoring minor files as well.
This tries to apply proper OOP patterns to the
DownloadClientCategoryFilterfile. I also tried to move files in proper folders to avoid the current situation with all files in the same place which makes them difficult to browse imhoChanges
Added
CategoryConfigurationclassRemoved
DownloadClientCategoryFilterfileTesting
Test coverage is not impacted as this is just a refactoring, no new feature or behavior change
Notes
These changes are purely optional