chore: use lizardbyte-common in c++#221
Draft
ReenigneArcher wants to merge 4 commits into
Draft
Conversation
Integrate lizardbyte-common library into the test build. Configure the submodule to be built as part of tests and link it to the test target. Update the lizardbyte-common submodule to the latest version.
Switch the test build from the local googletest submodule to `lizardbyte::test_support`. This removes `third-party/googletest` from submodules, enables `LIZARDBYTE_COMMON_BUILD_TEST_SUPPORT`, updates test linking/dependencies, and replaces direct `<gtest/gtest.h>` includes with `<lizardbyte/common/testing.h>`. Several fixture classes were also updated to inherit from `BaseTest` to align with the shared test support layer.
Bump `third-party/lizardbyte-common` from `4c05418359b38b09f3d5802243858a1d462a3b06` to `0fcde420419c77fdde04ffb04ceda0b560bd1cfc` to bring in the latest upstream changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #221 +/- ##
==========================================
- Coverage 63.16% 0.00% -63.17%
==========================================
Files 35 33 -2
Lines 5261 5242 -19
Branches 2385 2386 +1
==========================================
- Hits 3323 0 -3323
- Misses 1114 5014 +3900
+ Partials 824 228 -596
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
|
Bumps `third-party/lizardbyte-common` from `0fcde42` to `d219f38` to pull in the latest upstream common library changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use lizardbyte-common helpers.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage