feat(api/ui): add client enable/disable access control#4771
Open
neatnoise wants to merge 4 commits intoLizardByte:masterfrom
Open
feat(api/ui): add client enable/disable access control#4771neatnoise wants to merge 4 commits intoLizardByte:masterfrom
neatnoise wants to merge 4 commits intoLizardByte:masterfrom
Conversation
Member
|
@netnoise Could you rebase this? |
neatnoise
force-pushed
the
access-control
branch
from
9265238 to
36671e5
Compare
ReenigneArcher
force-pushed
the
access-control
branch
from
36671e5 to
49a1415
Compare
ReenigneArcher
requested changes
Mar 19, 2026
Member
ReenigneArcher
left a comment
ReenigneArcher
left a comment
There was a problem hiding this comment.
Thanks for the PR!
In addition to the review below, could you also update the api.md doc?
Bundle ReportChanges will increase total bundle size by 178 bytes (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sunshine-esmAssets Changed:
Files in
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4771 +/- ##
==========================================
- Coverage 17.91% 17.89% -0.02%
==========================================
Files 106 106
Lines 21980 22026 +46
Branches 9812 9841 +29
==========================================
+ Hits 3937 3941 +4
+ Misses 15825 13329 -2496
- Partials 2218 4756 +2538
Flags with carried forward coverage won't be shown. Click here to find out more.
|
neatnoise
force-pushed
the
access-control
branch
2 times, most recently
from
190ae59 to
b413b9d
Compare
Author
|
@ReenigneArcher Added changes to api.md, other suggestions, rebased the branch |
Member
ReenigneArcher
left a comment
ReenigneArcher
left a comment
There was a problem hiding this comment.
Thanks for the updates! Seems pretty good now, just one issue I noticed below. If you could fix that as well as the sonar warning (sorry to be a stickler about that, just trying to slowly get the code base to a nice state).
ReenigneArcher
approved these changes
Mar 29, 2026
Add ability to enable/disable paired clients via web UI and API. Disabled clients are rejected at TLS verification level. - Add enabled field to named_cert_t struct - Add /api/clients/update POST endpoint - Add enable/disable toggle in troubleshooting page - Persist enabled state in client credentials file
- confighttp.cpp: catch nlohmann::json::exception instead of std::exception - nvhttp.cpp: make client and named_cert const references in is_client_enabled
- Replace enable/disable button with Bootstrap switch toggle - Split auth checks and add CSRF validation per new pattern - Add @api_examples for updateClient endpoint - Remove blank doc comment line
…itch - Remove 8 duplicated route registrations in confighttp.cpp from rebase - Move /api/clients/update route to group with other client routes - Add required aria-checked attribute for role=switch accessibility
ReenigneArcher
force-pushed
the
access-control
branch
from
ad44115 to
ea00df6
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add ability to enable/disable paired clients via the web UI and API. Disabled clients are rejected at the TLS verification level, preventing them from connecting.
Changes:
enabledboolean field tonamed_cert_tstruct, persisted in client credentials filePOST /api/clients/updateendpoint accepting{ "uuid": "<uuid>", "enabled": true/false }set_client_enabled()andis_client_enabled()functions in nvhttpThis provides basic access control for paired clients without requiring a full unpair/re-pair cycle. Existing clients default to
enabled = truefor backward compatibility. When the client is disabled the visual behaviour of the Moonlight client is that the PC looks like turned off.Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage