build: use 4 part version scheme#20
Merged
Merged
Conversation
Documentation build overview
135 files changed ·
|
Replace allocation-based std::string/std::to_string usage in set_device_path with std::to_chars to write the numeric driver ID directly into the provided buffer. Add <charconv> include, remove unused <string>, and use memcpy for the constant prefix and '#' separator. Add a static_assert to ensure buffer capacity and handle to_chars errors by ensuring the buffer remains null-terminated. This avoids heap allocation and makes path formatting safer and more efficient.
ReenigneArcher
force-pushed
the
build/use-4-part-version-scheme
branch
from
ed51449 to
accc830
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20 +/- ##
=======================================
Coverage 86.50% 86.50%
=======================================
Files 12 12
Lines 3586 3586
Branches 1230 1230
=======================================
Hits 3102 3102
- Misses 333 349 +16
+ Partials 151 135 -16
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make versioning use 4 parts, which resolves an issue with the Windows driver, which requires version parts to be between 0 and 65535.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage