Fix: campaign_ensure_chapter incorrect due to slow animation#3676
Open
Air111 wants to merge 1 commit into
Open
Fix: campaign_ensure_chapter incorrect due to slow animation#3676Air111 wants to merge 1 commit into
Air111 wants to merge 1 commit into
Conversation
LmeSzinc
reviewed
Apr 24, 2024
Comment on lines
+47
to
+55
| if diff == 0: | ||
| break | ||
| # index=4, current=4, actual=14 | ||
| error_confirm_2.start() | ||
| if not error_confirm_2.reached(): | ||
| continue | ||
| else: | ||
| break | ||
| else: | ||
| error_confirm_2.clear() |
Owner
There was a problem hiding this comment.
在正常流程中不应有多余的截图或等待
正常流程指,预期切换到3图 实际也是3图,不需要切换章节的情况
Contributor
Author
There was a problem hiding this comment.
预期(index)切换到3图 实际(actual)也是3图,这样和“不正常”的流程一样index=3, current=3,除了多截一次图没有其他办法可以确定current==actual
5baad52 to
9c37bf4
Compare
Contributor
Author
|
减少一个timer,这样测着没啥问题。我们永远无法得知实际(actual)值,只能通过多截图/等待来增大current=actual的概率 while True:
self.device.click_record_clear()
self.ui_goto_main()
self.campaign.campaign_set_chapter_main('13')
self.ui_goto_main()
self.campaign.campaign_set_chapter_main('13')
self.ui_goto_main()
self.campaign.campaign_set_chapter_main('3') |
Owner
需要解决这个问题,否则PR不会被接受 |
Contributor
Author
|
想要没有多余的截图或等待,就要有“多余”的ocr和多服务器适配,或者“多余”的错误和重启。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

修复选择3-4但由于将13-4识别为3-4而出击13-4的问题