Skip to content

Added Null Checks to Util.cs (issue 403) #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
B0risev1ch wants to merge 3 commits into from
Closed

Added Null Checks to Util.cs (issue 403) #412

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
811bfb8
Added Null Checks to Util.cs
B0risev1ch Jun 6, 2025
267ca9b
Refactored Util.cs: added null checks and improved file name utilities
B0risev1ch Jun 14, 2025
e8fa909
Substitution cost in YetiLevenshtein(string s1, string s2) now treats…
B0risev1ch Jun 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/LogExpert.Core/Classes/Util.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@ public static int DamerauLevenshteinDistance (string src, string dest)

public static unsafe int YetiLevenshtein (string s1, string s2)
{
ArgumentNullException.ThrowIfNull(s1);
ArgumentNullException.ThrowIfNull(s2);
s1 ??= string.Empty;
Copy link
Copy Markdown
Contributor

@RandallFlagg RandallFlagg Jun 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this is a correct way to handle s1 and s2 in case of null. You are hiding the fact that there is a null there and I think that in case of null you should not even call this method.

In short:
I would like to know in case we got here with null and prevent it in the future.

s2 ??= string.Empty;

fixed (char* p1 = s1)
fixed (char* p2 = s2)
Expand Down
Loading