fix: invalid google user iam bug#2461
Merged
Merged
Conversation
SteffenDE
reviewed
Jun 25, 2025
SteffenDE
left a comment
SteffenDE
left a comment
Contributor
There was a problem hiding this comment.
I left some suggestions, mostly just refactoring opportunities :)
Base automatically changed from
ziinc/anl-931-logflare-service-account-provisioning
to
main
June 26, 2025 05:19
Ziinc
force-pushed
the
ziinc/anl-942-handle-deleted-google-accounts-bug
branch
from
966d6bc to
74ce2ff
Compare
djwhitt
pushed a commit
that referenced
this pull request
May 18, 2026
* feat: adding in iam management functions * feat: iam service account provisioning * feat: working service account impersonation * docs: add in docs around LOGFLARE_BIGQUERY_MANAGED_SA_POOL * feat: add in BigQueryAdaptor.set_iam_policy/0 wrapper * fix: phash on 0 value * chore: formatting * fix: add Projects copying * fix: invalid google user iam bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the iam policy provisioning, where invalid (deleted) google users are not removed from the provisioning, causing iam policy creation to fail.
Depends on #2433