refactor: removed nested function calls in SingleTenant module functions#3484
Conversation
nelsonmestevao
force-pushed
the
ne/refactor-removed-nested-function-calls-in-singletenant-modul
branch
3 times, most recently
from
ed97f27 to
77307a9
Compare
| end | ||
|
|
||
| test "Logflare.Application.startup_tasks/0 should insert plan and user" do | ||
| expect(BigQueryAdaptor, :update_iam_policy, fn -> :ok end) |
There was a problem hiding this comment.
To remove the error log about IAM policies 🙏
There was a problem hiding this comment.
i think we should stub the underlying library function globally so that we can silence all related errors that get emitted, pretty sure some error logs are getting emitted due to us not stubbing it in the ConnCase/DataCase.
Can you do a followup for this? 🙏
There was a problem hiding this comment.
once we have it in place then we won't need this expect anymore.
nelsonmestevao
force-pushed
the
ne/refactor-removed-nested-function-calls-in-singletenant-modul
branch
6 times, most recently
from
e404eb7 to
773f7a3
Compare
nelsonmestevao
force-pushed
the
ne/refactor-removed-nested-function-calls-in-singletenant-modul
branch
from
773f7a3 to
30ba15f
Compare
| end | ||
|
|
||
| test "Logflare.Application.startup_tasks/0 should insert plan and user" do | ||
| expect(BigQueryAdaptor, :update_iam_policy, fn -> :ok end) |
There was a problem hiding this comment.
i think we should stub the underlying library function globally so that we can silence all related errors that get emitted, pretty sure some error logs are getting emitted due to us not stubbing it in the ConnCase/DataCase.
Can you do a followup for this? 🙏
| end | ||
|
|
||
| test "Logflare.Application.startup_tasks/0 should insert plan and user" do | ||
| expect(BigQueryAdaptor, :update_iam_policy, fn -> :ok end) |
There was a problem hiding this comment.
once we have it in place then we won't need this expect anymore.
2 participants
These are offenses in the latest version of credo.