refactor: extract email notification helpers from nested code#3524
Open
nelsonmestevao wants to merge 2 commits into
Open
refactor: extract email notification helpers from nested code#3524nelsonmestevao wants to merge 2 commits into
nelsonmestevao wants to merge 2 commits into
Conversation
nelsonmestevao
changed the title
nelsonmestevao
force-pushed
the
ne/source-emails
branch
from
51f991e to
86991d7
Compare
Ziinc
requested changes
May 25, 2026
| end | ||
|
|
||
| defp notify_user(source, rate) do | ||
| if source.notifications.user_email_notifications do |
Contributor
Author
There was a problem hiding this comment.
I am not sure what you mean. On the function signature like so?
Suggested change
| if source.notifications.user_email_notifications do | |
| defp notify_user(source = %{notifications: %{user_email_notifications: true}}, rate) do |
Contributor
There was a problem hiding this comment.
yup that's what i mean, but just a small nit
nelsonmestevao
force-pushed
the
ne/source-emails
branch
4 times, most recently
from
0869703 to
1821dc8
Compare
nelsonmestevao
force-pushed
the
ne/source-emails
branch
5 times, most recently
from
6153692 to
65086e0
Compare
nelsonmestevao
force-pushed
the
ne/source-emails
branch
from
65086e0 to
c193bbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.