refactor: clean up PaymentMethodComponent and surface Stripe errors#3570
Open
laraujo7 wants to merge 1 commit into
Open
refactor: clean up PaymentMethodComponent and surface Stripe errors#3570laraujo7 wants to merge 1 commit into
laraujo7 wants to merge 1 commit into
Conversation
laraujo7
force-pushed
the
la/payment_method_component
branch
from
b519eaa to
61177d6
Compare
nelsonmestevao
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add error handling to the sync and make-default flows so Stripe failures flash a real error message instead of silently failing. Also refactors the component to use attr-typed function components and modern :for/:if templates, removes the unused
loadingassign.