[volume-10] Collect, Stack, Zip

.github/workflows/main.yml

@@ -0,0 +1,13 @@
+name: PR Agent
+on:
+  pull_request:
+    types: [opened, synchronize]
+jobs:
+  pr_agent_job:
+    runs-on: ubuntu-latest
+    steps:
+      - name: PR Agent action step
+        uses: Codium-ai/pr-agent@main
+        env:
+          OPENAI_KEY: ${{ secrets.OPENAI_KEY }}
+          GITHUB_TOKEN: ${{ secrets.G_TOKEN }}

apps/commerce-api/src/main/java/com/loopers/application/like/LikeFacade.java

@@ -3,7 +3,6 @@
 import com.loopers.domain.like.LikeService;
 import lombok.RequiredArgsConstructor;
 import org.springframework.stereotype.Component;
-import org.springframework.transaction.annotation.Transactional;
 
 /**
  * packageName : com.loopers.application.like
@@ -18,7 +17,6 @@
  */
 @Component
 @RequiredArgsConstructor
-@Transactional
 public class LikeFacade {
 
     private final LikeService likeService;

apps/commerce-api/src/main/java/com/loopers/domain/brand/BrandService.java

@@ -23,7 +23,6 @@ public class BrandService {
 
     private final BrandRepository brandRepository;
 
-    @Transactional
     public void save(Brand brand) {
         brandRepository.save(brand);
     }

apps/commerce-api/src/main/java/com/loopers/domain/order/Order.java

@@ -55,6 +55,7 @@ public static Order create(String userId) {
     }
 
     public void addOrderItem(OrderItem orderItem) {
+        orderItem.setOrder(this);
         this.orderItems.add(orderItem);
     }
 

apps/commerce-api/src/main/java/com/loopers/domain/point/Point.java

@@ -42,7 +42,6 @@ public void charge(Long chargeAmount) {
             throw new CoreException(ErrorType.BAD_REQUEST, "0원 이하로 포인트를 충전 할수 없습니다.");
         }
         this.balance += chargeAmount;
-        new Point(this.userId, this.balance);
     }
 
     public void use(Long useAmount) {

apps/commerce-api/src/main/java/com/loopers/domain/point/PointService.java

@@ -36,11 +36,11 @@ public Point usePoint(String userId, Long useAmount) {
                 .orElseThrow(() -> new CoreException(ErrorType.NOT_FOUND, "포인트 정보를 찾을 수 없습니다."));
 
         if (useAmount == null || useAmount <= 0) {
-            throw new CoreException(ErrorType.NOT_FOUND, "차감할 포인트는 1 이상이어야 합니다.");
+            throw new CoreException(ErrorType.BAD_REQUEST, "차감할 포인트는 1 이상이어야 합니다.");
         }
 
         if (point.getBalance() < useAmount) {
-            throw new CoreException(ErrorType.NOT_FOUND, "포인트가 부족합니다.");
+            throw new CoreException(ErrorType.BAD_REQUEST, "포인트가 부족합니다.");
         }
 
         point.use(useAmount);

apps/commerce-api/src/main/java/com/loopers/domain/product/Product.java

@@ -85,14 +85,17 @@ private Long requireValidPrice(Long price) {
         return price;
     }
 
-    public Long requireValidLikeCount(Long likeCount) {
+    private Long requireValidLikeCount(Long likeCount) {
         if (likeCount == null || likeCount < 0) {
             throw new CoreException(ErrorType.BAD_REQUEST, "좋아요 개수는 0개 미만으로 설정할 수 없습니다.");
         }
         return likeCount;
     }
 
     private Long requireValidStock(Long stock) {
+        if (stock == null) {
+            throw new CoreException(ErrorType.BAD_REQUEST, "상품 재고는 필수입니다.");
+        }
         if (stock < 0) {
             throw new CoreException(ErrorType.BAD_REQUEST, "상품 재고는 0 미만으로 설정할 수 없습니다.");
         }

apps/commerce-api/src/main/java/com/loopers/domain/product/ProductDomainService.java

@@ -7,6 +7,7 @@
 import com.loopers.support.error.ErrorType;
 import lombok.RequiredArgsConstructor;
 import org.springframework.stereotype.Component;
+import org.springframework.transaction.annotation.Transactional;
 
 /**
  * packageName : com.loopers.domain.product
@@ -27,6 +28,7 @@ public class ProductDomainService {
     private final BrandRepository brandRepository;
     private final LikeRepository likeRepository;
 
+    @Transactional(readOnly = true)
     public ProductDetail getProductDetail(Long id) {
         Product product = productRepository.findById(id)
                 .orElseThrow(() -> new CoreException(ErrorType.NOT_FOUND, "상품을 찾을 수 없습니다."));

apps/commerce-api/src/main/java/com/loopers/domain/user/UserService.java

@@ -15,7 +15,7 @@ public class UserService {
     @Transactional
     public User register(String userId, String email, String birth, String gender) {
         userRepository.findByUserId(userId).ifPresent(user -> {
-            throw new CoreException(ErrorType.CONFLICT, "이미 가입된 사용자ID 입니다.");
+            throw new CoreException(ErrorType.CONFLICT, "이미 가입된 사용자 ID 입니다.");
         });
 
         User user = new User(userId, email, birth, gender);

apps/commerce-api/src/main/java/com/loopers/infrastructure/brand/BrandJpaRepository.java

@@ -3,8 +3,6 @@
 import com.loopers.domain.brand.Brand;
 import org.springframework.data.jpa.repository.JpaRepository;
 
-import java.util.Optional;
-
 /**
  * packageName : com.loopers.infrastructure.brand
  * fileName     : BrandJpaRepository
@@ -17,5 +15,4 @@
  * 2025. 11. 12.     byeonsungmun       최초 생성
  */
 public interface BrandJpaRepository extends JpaRepository<Brand, Long> {
-    Optional<Brand> findById(Long id);
 }

apps/commerce-api/src/main/java/com/loopers/infrastructure/product/ProductRepositoryImpl.java

@@ -2,6 +2,8 @@
 
 import com.loopers.domain.product.Product;
 import com.loopers.domain.product.ProductRepository;
+import com.loopers.support.error.CoreException;
+import com.loopers.support.error.ErrorType;
 import lombok.RequiredArgsConstructor;
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.Pageable;
@@ -38,13 +40,15 @@ public Optional<Product> findById(Long id) {
 
     @Override
     public void incrementLikeCount(Long productId) {
-        Product product = productJpaRepository.findById(productId).get();
+        Product product = productJpaRepository.findById(productId)
+                .orElseThrow(() -> new CoreException(ErrorType.NOT_FOUND, "상품을 찾을수 없습니다."));
         product.increaseLikeCount();
     }
 
     @Override
     public void decrementLikeCount(Long productId) {
-        Product product = productJpaRepository.findById(productId).get();
+        Product product = productJpaRepository.findById(productId)
+                .orElseThrow(() -> new CoreException(ErrorType.NOT_FOUND, "상품을 찾을수 없습니다."));
         product.decreaseLikeCount();
     }
 

apps/commerce-api/src/main/java/com/loopers/infrastructure/user/UserRepositoryImpl.java

@@ -20,8 +20,7 @@ public Optional<User> findByUserId(String userId) {
 
     @Override
     public User save(User user) {
-        userJpaRepository.save(user);
-        return user;
+        return userJpaRepository.save(user);
     }
 }
 

apps/commerce-api/src/main/java/com/loopers/interfaces/api/point/PointV1ApiSpec.java

@@ -22,7 +22,7 @@ ApiResponse<PointV1Dto.PointResponse> getPoint(
             description = "회원의 포인트를 충전한다."
     )
     ApiResponse<PointV1Dto.PointResponse> chargePoint(
-            @Schema(name = "포인트 충전 요청", description = "조회할 회원 ID")
+            @Schema(name = "포인트 충전 요청", description = "충전할 포인트 정보를 포함한 요청")
             PointV1Dto.ChargePointRequest request
     );
 }

apps/commerce-api/src/test/java/com/loopers/domain/user/UserTest.java

@@ -42,12 +42,12 @@ void throwsException_whenInvalidEmailFormat() {
         void throwsException_whenInvalidBirthFormat() {
             // given
             String userId = "yh45g";
-            String invalidEmail = "invalid-email-format"; // '@' 없음
-            String birth = "1994-12-05";
+            String email = "valid@loopers.com";
+            String invalidBirth = "19941205"; // 형식 오류: 하이픈 없음
             String gender = "MALE";
 
             // when & then
-            assertThrows(CoreException.class, () -> new User(userId, invalidEmail, birth, gender));
+            assertThrows(CoreException.class, () -> new User(userId, email, invalidBirth, gender));
         }
     }
 }

apps/commerce-batch/build.gradle.kts

@@ -0,0 +1,21 @@
+dependencies {
+    // add-ons
+    implementation(project(":modules:jpa"))
+    implementation(project(":modules:redis"))
+    implementation(project(":supports:jackson"))
+    implementation(project(":supports:logging"))
+    implementation(project(":supports:monitoring"))
+
+    // batch
+    implementation("org.springframework.boot:spring-boot-starter-batch")
+    testImplementation("org.springframework.batch:spring-batch-test")
+
+    // querydsl
+    annotationProcessor("com.querydsl:querydsl-apt::jakarta")
+    annotationProcessor("jakarta.persistence:jakarta.persistence-api")
+    annotationProcessor("jakarta.annotation:jakarta.annotation-api")
+
+    // test-fixtures
+    testImplementation(testFixtures(project(":modules:jpa")))
+    testImplementation(testFixtures(project(":modules:redis")))
+}

apps/commerce-batch/src/main/java/com/loopers/CommerceBatchApplication.java

@@ -0,0 +1,24 @@
+package com.loopers;
+
+import jakarta.annotation.PostConstruct;
+import org.springframework.boot.SpringApplication;
+import org.springframework.boot.autoconfigure.SpringBootApplication;
+import org.springframework.boot.context.properties.ConfigurationPropertiesScan;
+
+import java.util.TimeZone;
+
+@ConfigurationPropertiesScan
+@SpringBootApplication
+public class CommerceBatchApplication {
+
+    @PostConstruct
+    public void started() {
+        // set timezone
+        TimeZone.setDefault(TimeZone.getTimeZone("Asia/Seoul"));
+    }
+
+    public static void main(String[] args) {
+        int exitCode = SpringApplication.exit(SpringApplication.run(CommerceBatchApplication.class, args));
+        System.exit(exitCode);
+    }
+}

apps/commerce-batch/src/main/java/com/loopers/batch/job/demo/DemoJobConfig.java

@@ -0,0 +1,48 @@
+package com.loopers.batch.job.demo;
+
+import com.loopers.batch.job.demo.step.DemoTasklet;
+import com.loopers.batch.listener.JobListener;
+import com.loopers.batch.listener.StepMonitorListener;
+import lombok.RequiredArgsConstructor;
+import org.springframework.batch.core.Job;
+import org.springframework.batch.core.Step;
+import org.springframework.batch.core.configuration.annotation.JobScope;
+import org.springframework.batch.core.job.builder.JobBuilder;
+import org.springframework.batch.core.launch.support.RunIdIncrementer;
+import org.springframework.batch.core.repository.JobRepository;
+import org.springframework.batch.core.step.builder.StepBuilder;
+import org.springframework.batch.support.transaction.ResourcelessTransactionManager;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+
+@ConditionalOnProperty(name = "spring.batch.job.name", havingValue = DemoJobConfig.JOB_NAME)
+@RequiredArgsConstructor
+@Configuration
+public class DemoJobConfig {
+    public static final String JOB_NAME = "demoJob";
+    private static final String STEP_DEMO_SIMPLE_TASK_NAME = "demoSimpleTask";
+
+    private final JobRepository jobRepository;
+    private final JobListener jobListener;
+    private final StepMonitorListener stepMonitorListener;
+    private final DemoTasklet demoTasklet;
+
+    @Bean(JOB_NAME)
+    public Job demoJob() {
+        return new JobBuilder(JOB_NAME, jobRepository)
+                .incrementer(new RunIdIncrementer())
+                .start(categorySyncStep())
+                .listener(jobListener)
+                .build();
+    }
+
+    @JobScope
+    @Bean(STEP_DEMO_SIMPLE_TASK_NAME)
+    public Step categorySyncStep() {
+        return new StepBuilder(STEP_DEMO_SIMPLE_TASK_NAME, jobRepository)
+                .tasklet(demoTasklet, new ResourcelessTransactionManager())
+                .listener(stepMonitorListener)
+                .build();
+    }
+}

apps/commerce-batch/src/main/java/com/loopers/batch/job/demo/step/DemoTasklet.java

@@ -0,0 +1,32 @@
+package com.loopers.batch.job.demo.step;
+
+import com.loopers.batch.job.demo.DemoJobConfig;
+import lombok.RequiredArgsConstructor;
+import org.springframework.batch.core.StepContribution;
+import org.springframework.batch.core.configuration.annotation.StepScope;
+import org.springframework.batch.core.scope.context.ChunkContext;
+import org.springframework.batch.core.step.tasklet.Tasklet;
+import org.springframework.batch.repeat.RepeatStatus;
+import org.springframework.beans.factory.annotation.Value;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
+import org.springframework.stereotype.Component;
+
+@StepScope
+@ConditionalOnProperty(name = "spring.batch.job.name", havingValue = DemoJobConfig.JOB_NAME)
+@RequiredArgsConstructor
+@Component
+public class DemoTasklet implements Tasklet {
+    @Value("#{jobParameters['requestDate']}")
+    private String requestDate;
+
+    @Override
+    public RepeatStatus execute(StepContribution contribution, ChunkContext chunkContext) throws Exception {
+        if (requestDate == null) {
+            throw new RuntimeException("requestDate is null");
+        }
+        System.out.println("Demo Tasklet 실행 (실행 일자 : " + requestDate + ")");
+        Thread.sleep(1000);
+        System.out.println("Demo Tasklet 작업 완료");
+        return RepeatStatus.FINISHED;
+    }
+}

apps/commerce-batch/src/main/java/com/loopers/batch/listener/ChunkListener.java

@@ -0,0 +1,21 @@
+package com.loopers.batch.listener;
+
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import org.springframework.batch.core.annotation.AfterChunk;
+import org.springframework.batch.core.scope.context.ChunkContext;
+import org.springframework.stereotype.Component;
+
+@Slf4j
+@RequiredArgsConstructor
+@Component
+public class ChunkListener {
+
+    @AfterChunk
+    void afterChunk(ChunkContext chunkContext) {
+        log.info(
+            "청크 종료: readCount: ${chunkContext.stepContext.stepExecution.readCount}, " +
+                    "writeCount: ${chunkContext.stepContext.stepExecution.writeCount}"
+        );
+    }
+}

apps/commerce-batch/src/main/java/com/loopers/batch/listener/JobListener.java

@@ -0,0 +1,53 @@
+package com.loopers.batch.listener;
+
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import org.springframework.batch.core.JobExecution;
+import org.springframework.batch.core.annotation.AfterJob;
+import org.springframework.batch.core.annotation.BeforeJob;
+import org.springframework.stereotype.Component;
+
+import java.time.Duration;
+import java.time.Instant;
+import java.time.ZoneId;
+
+@Slf4j
+@RequiredArgsConstructor
+@Component
+public class JobListener {
+
+    @BeforeJob
+    void beforeJob(JobExecution jobExecution) {
+        log.info("Job '${jobExecution.jobInstance.jobName}' 시작");
+        jobExecution.getExecutionContext().putLong("startTime", System.currentTimeMillis());
+    }
+
+    @AfterJob
+    void afterJob(JobExecution jobExecution) {
+        var startTime = jobExecution.getExecutionContext().getLong("startTime");
+        var endTime = System.currentTimeMillis();
+
+        var startDateTime = Instant.ofEpochMilli(startTime)
+            .atZone(ZoneId.systemDefault())
+            .toLocalDateTime();
+        var endDateTime = Instant.ofEpochMilli(endTime)
+            .atZone(ZoneId.systemDefault())
+            .toLocalDateTime();
+
+        var totalTime = endTime - startTime;
+        var duration = Duration.ofMillis(totalTime);
+        var hours = duration.toHours();
+        var minutes = duration.toMinutes() % 60;
+        var seconds = duration.getSeconds() % 60;
+
+        var message = String.format(
+            """
+                *Start Time:* %s
+                *End Time:* %s
+                *Total Time:* %d시간 %d분 %d초
+            """, startDateTime, endDateTime, hours, minutes, seconds
+        ).trim();
+
+        log.info(message);
+    }
+}