Skip to content

Fix data loss bug in header_remover during in-place removal - #167

Merged
ClausValcaTD merged 1 commit into
mainfrom
fix-header-remover-in-place-truncation-3235125612171155444
Oct 20, 2026
Merged

ClausValcaTD merged 1 commit into
mainfrom
fix-header-remover-in-place-truncation-3235125612171155444

Conversation

@ClausValcaTD

Copy link
Copy Markdown
Contributor

This PR resolves a critical data loss bug in header_remover.dart where in-place header removal (e.g. outputDir omitted/null and backup: false) opened the target file with FileMode.write while reading from it, truncating the file to 0 bytes.

Changes:

  1. Updated removeHeader to write cleaned bytes to a temporary file ($cleanPath.tmp) first.
  2. Ensured stream handles are closed before replacing the target file using renameSync with copySync fallback.
  3. Added try-finally cleanup logic to delete the temporary file if an exception occurs during execution.
  4. Added unit test in core/test/header_remover_test.dart verifying in-place header removal with backup: false on a dummy ROM.

PR created automatically by Jules for task 3235125612171155444 started by @ClausValcaTD

Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ClausValcaTD
ClausValcaTD merged commit 3e64d12 into main Oct 20, 2026
1 check passed
@ClausValcaTD
ClausValcaTD deleted the fix-header-remover-in-place-truncation-3235125612171155444 branch October 20, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant