Repository navigation
Fix data loss bug in header_remover during in-place removal - #167
ClausValcaTD merged 1 commit into
Conversation
Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR resolves a critical data loss bug in
header_remover.dartwhere in-place header removal (e.g.outputDiromitted/null andbackup: false) opened the target file withFileMode.writewhile reading from it, truncating the file to 0 bytes.Changes:
removeHeaderto write cleaned bytes to a temporary file ($cleanPath.tmp) first.renameSyncwithcopySyncfallback.core/test/header_remover_test.dartverifying in-place header removal withbackup: falseon a dummy ROM.PR created automatically by Jules for task 3235125612171155444 started by @ClausValcaTD