Skip to content

Fix 1G1R clustering logic, streaming ZIP extraction, and CLI docs - #168

Merged
ClausValcaTD merged 1 commit into
mainfrom
fix-1g1r-and-compressor-8074737114512042670
Oct 20, 2026
Merged

ClausValcaTD merged 1 commit into
mainfrom
fix-1g1r-and-compressor-8074737114512042670

Conversation

@ClausValcaTD

Copy link
Copy Markdown
Contributor
  • Changed 1G1R default dryRun value to true to avoid modifying user files by default.
  • Updated extractCleanTitle in one_g_one_r.dart to preserve multi-disc tags (Disc 1, Disc A, CD 1, etc.).
  • Filtered companion and sidecar files (.cue, .m3u, .sav, save states, track .bin files) from being grouped into duplicate candidates.
  • Added pre-release penalty score so commercial releases take priority over Beta/Proto/Demo/Sample builds.
  • Refactored zip extraction in compressor.dart to use InputFileStream and OutputFileStream for streamed/chunked reading and writing to prevent OOM errors on large archives.
  • Explicitly throw UnsupportedError when 7Z format is requested.
  • Updated README.md and core/bin/openrom.dart help documentation to specify supported archive formats and clarify generic patching vs DCP patching options.
  • Added unit tests in core/test/ for 1G1R improvements and compressor behavior.

PR created automatically by Jules for task 8074737114512042670 started by @ClausValcaTD

- Change 1G1R default dryRun value to true.
- Preserve multi-disc tags (Disc 1, Disc A, CD 1, etc.) during title extraction.
- Filter companion/sidecar files (.cue, .m3u, .sav, etc.) from 1G1R duplicate candidates.
- Add pre-release penalty ranking so commercial releases rank higher than beta/proto/demo builds.
- Implement chunked/streamed ZIP extraction in compressor.dart using InputFileStream and OutputFileStream.
- Throw UnsupportedError when 7z format is requested.
- Update CLI openrom.dart help strings and README.md archive format documentation.
- Add unit tests for 1G1R fixes and compressor streaming and format error handling.

Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ClausValcaTD
ClausValcaTD merged commit a81f3e1 into main Oct 20, 2026
1 check failed
@ClausValcaTD
ClausValcaTD deleted the fix-1g1r-and-compressor-8074737114512042670 branch October 20, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant