v1.0.4-preview.3 #14
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -278,6 +278,9 @@ func migrateDB() error { | |
| if err := migrateTokenModelLimitsToText(); err != nil { | ||
| return err | ||
| } | ||
| if err := migrateUserQuotaColumnsToBigInt(); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| err := DB.AutoMigrate( | ||
| &Channel{}, | ||
|
|
@@ -331,6 +334,9 @@ func migrateDB() error { | |
| } | ||
|
|
||
| func migrateDBFast() error { | ||
| if err := migrateUserQuotaColumnsToBigInt(); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| var wg sync.WaitGroup | ||
|
|
||
|
|
@@ -660,6 +666,55 @@ func migrateTokenModelLimitsToText() error { | |
| return nil | ||
| } | ||
|
|
||
| func migrateUserQuotaColumnsToBigInt() error { | ||
| if DB == nil || common.UsingSQLite || !DB.Migrator().HasTable(&User{}) { | ||
| return nil | ||
| } | ||
|
|
||
| tableName := "users" | ||
| columnNames := []string{"quota", "used_quota", "aff_quota", "aff_history"} | ||
|
|
||
| for _, columnName := range columnNames { | ||
| if !DB.Migrator().HasColumn(&User{}, columnName) { | ||
| continue | ||
| } | ||
|
|
||
| var alterSQL string | ||
| if common.UsingPostgreSQL { | ||
| var dataType string | ||
| if err := DB.Raw(`SELECT data_type FROM information_schema.columns | ||
| WHERE table_schema = current_schema() AND table_name = ? AND column_name = ?`, | ||
| tableName, columnName).Scan(&dataType).Error; err != nil { | ||
| common.SysLog(fmt.Sprintf("Warning: failed to query metadata for %s.%s: %v", tableName, columnName, err)) | ||
| } else if strings.EqualFold(dataType, "bigint") { | ||
| continue | ||
| } | ||
| alterSQL = fmt.Sprintf(`ALTER TABLE "%s" ALTER COLUMN "%s" TYPE bigint USING "%s"::bigint`, | ||
| tableName, columnName, columnName) | ||
| } else if common.UsingMySQL { | ||
| var columnType string | ||
| if err := DB.Raw(`SELECT COLUMN_TYPE FROM information_schema.columns | ||
| WHERE table_schema = DATABASE() AND table_name = ? AND column_name = ?`, | ||
| tableName, columnName).Scan(&columnType).Error; err != nil { | ||
| common.SysLog(fmt.Sprintf("Warning: failed to query metadata for %s.%s: %v", tableName, columnName, err)) | ||
| } else if strings.HasPrefix(strings.ToLower(columnType), "bigint") { | ||
| continue | ||
| } | ||
| alterSQL = fmt.Sprintf("ALTER TABLE `%s` MODIFY COLUMN `%s` bigint DEFAULT 0", tableName, columnName) | ||
|
Comment on lines
+694
to
+703
There was a problem hiding this comment. 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '--- model/main.go around 660-730 ---'
sed -n '660,730p' model/main.go
echo
echo '--- search quota-related definitions/usages ---'
rg -n "quota|used_quota|aff_quota|aff_history" model . --glob '!**/vendor/**' --glob '!**/node_modules/**'Repository: MAX-API-Next/MAX-API Length of output: 50377 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '--- model/user.go struct around quota fields ---'
sed -n '50,85p' model/user.go
echo
echo '--- search for user table migrations / schema creation ---'
rg -n "AutoMigrate|CreateTable|quota.*not null|used_quota.*not null|aff_quota.*not null|aff_history.*not null|type:bigint;default:0" model --glob '!**/vendor/**' --glob '!**/node_modules/**'Repository: MAX-API-Next/MAX-API Length of output: 4935 🌐 Web query:
💡 Result: In GORM v2, AutoMigrate handles integer field nullable/NOT NULL constraints based on the Go struct type definition and GORM tags [1][2][3]. 1. Field Nullability: By default, Go primitive types (e.g., int, int64) are treated as non-nullable [3]. To make an integer field nullable, use a pointer type (e.g., *int) or sql.NullInt64 [4][5][3]. 2. NOT NULL Constraint: Use the Citations:
Preserve the existing 🤖 Prompt for AI Agents |
||
| } | ||
|
|
||
| if alterSQL == "" { | ||
| continue | ||
| } | ||
| if err := DB.Exec(alterSQL).Error; err != nil { | ||
| return fmt.Errorf("failed to migrate %s.%s to bigint: %w", tableName, columnName, err) | ||
| } | ||
| common.SysLog(fmt.Sprintf("Successfully migrated %s.%s to bigint", tableName, columnName)) | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
|
Comment on lines
+669
to
+717
There was a problem hiding this comment. 🧹 Nitpick | 🔵 Trivial Raw-SQL pre-migration for a large
🤖 Prompt for AI Agents |
||
| // migrateSubscriptionPlanPriceAmount migrates price_amount column from float/double to decimal(10,6) | ||
| // This is safe to run multiple times - it checks the column type first | ||
| func migrateSubscriptionPlanPriceAmount() { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win
Test doesn't exercise the actual int64-max boundary or overflow protection.
The updated assertions only prove values beyond the old int32 limit are now accepted; they don't cover the new overflow-safe subtraction check (
current <= maxUserQuotaValue-delta) near the realmaxUserQuotaValueboundary, which is the actual correctness improvement inisValidQuotaAddition.✅ Suggested additional boundary cases
📝 Committable suggestion
🤖 Prompt for AI Agents