feat: Stellar transfer lifecycle state machine#661
Open
michaelvic123 wants to merge 2 commits into
Open
Conversation
Implements a guarded state machine for Soroban bridge transfer lifecycle management under src/transfers/state-machine/stellar/. States: pending -> locked -> validated -> submitted -> confirmed -> completed Recovery: failed -> refunded (via /recover endpoint) - transfer-state-machine.types.ts: TransferState, TransitionRecord, TransferLifecycle - transfer-state-machine.service.ts: create/get/transition/recover with transition guards - transfer-state-machine.controller.ts: REST endpoints with Swagger - transfer-state-machine.module.ts: NestJS module, exports service for reuse - app.module.ts: registers TransferStateMachineModule
|
@michaelvic123 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Collaborator
|
Hello @michaelvic123 kindly fix the run build errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #517
Summary
Implements a guarded state machine for Soroban bridge transfer lifecycle management at
src/transfers/state-machine/stellar/.Problem
Transfer states were handled inconsistently — callers could set any status directly with no transition validation, leading to unreachable or invalid states.
Solution
A NestJS service that holds per-transfer state machines in memory and enforces valid transitions at every step.
Transfer States
Endpoints
POST /transfers/state-machine/stellar/:transferId— create lifecycle for a transferGET /transfers/state-machine/stellar/:transferId— get current state + historyPOST /transfers/state-machine/stellar/:transferId/transition— move to next state (guarded)POST /transfers/state-machine/stellar/:transferId/recover— recovery path: failed → refundedFiles
transfer-state-machine.types.ts—TransferState,TransitionRecord,TransferLifecycletransfer-state-machine.service.ts—create/get/transition/recoverwith guards, exports servicetransfer-state-machine.controller.ts— REST + Swaggertransfer-state-machine.module.ts— NestJS moduleapp.module.ts— registersTransferStateMachineModuleVerified
400 BadRequestExceptionwith clear message