Soroban Unsafe Operations Detection Rule

packages/rules/src/lib.rs

@@ -11,11 +11,11 @@ pub mod vyper;
 // Explicitly export core types to avoid ambiguity
 pub use optimization::deployment::{estimate_bytecode_size, ExcessiveContractSizeRule};
 pub use optimization::storage::{
-    detect_packing_opportunities, find_consecutive_packable_groups, get_type_size,
-    is_packable_type, PackingOpportunity, VariableInfo,
-};
-pub use rule_engine::{
-    extract_struct_fields, find_variable_usage, Rule, RuleEngine, RuleViolation, ViolationSeverity,
+    detect_packing_opportunities,
+    find_consecutive_packable_groups,
+    get_type_size,
+    PackingOpportunity,
+    VariableInfo,
 };
 pub use security::{HardcodedAddressesRule, MissingDomainSeparationRule};
 pub use solidity::{StateVariablePackingRule, MappingIterationRule};

packages/rules/src/stellar/linting/gas_optimization_rules.rs

@@ -34,14 +34,8 @@ impl SorobanLintRule for StorageReadRule {
             // Check for multiple .get() calls on same storage
             if line.contains(".get(") {
                 // Look for repeated patterns
-                let func_lines = lines
-                    .iter()
-                    .skip(i.saturating_sub(20))
-                    .take(40)
-                    .copied()
-                    .collect::<Vec<_>>()
-                    .join("\n");
-
+                let func_lines = lines.iter().skip(i.saturating_sub(20)).take(40).copied().collect::<Vec<&str>>().join("\n");
+
                 let get_count = func_lines.matches(".get(").count();
                 if get_count > 2 {
                     violations.push(RuleViolation {
@@ -95,20 +89,9 @@ impl SorobanLintRule for MapIterationRule {
         let lines: Vec<&str> = source.lines().collect();
 
         for (i, line) in lines.iter().enumerate() {
-            if (line.contains("for ") || line.contains("while "))
-                && (line.contains(".iter()")
-                    || line.contains(".keys(")
-                    || line.contains(".values(")
-                    || line.contains(".entries(")
-                    || line.contains(".range("))
-            {
-                let window = lines
-                    .iter()
-                    .skip(i.saturating_sub(8))
-                    .take(20)
-                    .copied()
-                    .collect::<Vec<_>>()
-                    .join("\n");
+            if (line.contains("for ") || line.contains("while ")) &&
+               (line.contains(".iter()") || line.contains(".keys(") || line.contains(".values(") || line.contains(".entries(") || line.contains(".range(")) {
+                let window = lines.iter().skip(i.saturating_sub(8)).take(20).copied().collect::<Vec<&str>>().join("\n");
                 if window.contains("Map<") || window.contains("Map::") || window.contains(": Map") {
                     violations.push(RuleViolation {
                         rule_name: self.id().to_string(),
@@ -191,17 +174,9 @@ impl SorobanLintRule for EventEmissionRule {
             let lines: Vec<&str> = source.lines().collect();
 
             for (i, line) in lines.iter().enumerate() {
-                if line.contains("pub fn")
-                    && (line.contains("transfer") || line.contains("mint") || line.contains("burn"))
-                {
-                    let func_lines = lines
-                        .iter()
-                        .skip(i)
-                        .take(20)
-                        .copied()
-                        .collect::<Vec<_>>()
-                        .join("\n");
-
+                if line.contains("pub fn") && (line.contains("transfer") || line.contains("mint") || line.contains("burn")) {
+                    let func_lines = lines.iter().skip(i).take(20).copied().collect::<Vec<&str>>().join("\n");
+
                     if !func_lines.contains("events().publish(") {
                         violations.push(RuleViolation {
                             rule_name: self.id().to_string(),
@@ -247,7 +222,8 @@ impl MyContract {
 }
 "#;
 
-        let violations = MapIterationRule.check(source, "test.rs");
+        let rule = MapIterationRule;
+        let violations = rule.check(source, "test.rs");
         assert!(violations.is_some());
         let violations = violations.unwrap();
         assert!(violations
@@ -270,7 +246,8 @@ impl MyContract {
 }
 "#;
 
-        let violations = MapIterationRule.check(source, "test.rs");
+        let rule = MapIterationRule;
+        let violations = rule.check(source, "test.rs");
         assert!(violations.is_none());
     }
 }

packages/rules/src/stellar/linting/mod.rs

@@ -14,6 +14,7 @@ pub use soroban_rules::*;
 pub use stellar_sdk_rules::*;
 
 use crate::{RuleViolation, ViolationSeverity};
+use crate::stellar::unsafe_operations::UnsafeOperationsRule;
 
 /// Main linting engine for Soroban contracts
 pub struct SorobanLinter {
@@ -35,7 +36,8 @@ impl SorobanLinter {
         rules.push(Box::new(gas_optimization_rules::MapIterationRule));
         rules.push(Box::new(gas_optimization_rules::EventEmissionRule));
         rules.push(Box::new(networking::NetworkValidationRule));
-
+        rules.push(Box::new(UnsafeOperationsRule));
+
         Self { rules }
     }
 

packages/rules/src/stellar/linting/soroban_rules.rs

@@ -112,13 +112,7 @@ impl SorobanLintRule for EnvParameterRule {
             if line.contains("pub fn") && !line.contains("Env") {
                 // Check if function body has storage operations
                 if i + 1 < lines.len() {
-                    let next_lines = lines
-                        .iter()
-                        .skip(i)
-                        .take(10)
-                        .copied()
-                        .collect::<Vec<_>>()
-                        .join("\n");
+                    let next_lines = lines.iter().skip(i).take(10).copied().collect::<Vec<&str>>().join("\n");
                     if next_lines.contains(".set(") || next_lines.contains(".put(") {
                         violations.push(RuleViolation {
                             rule_name: self.id().to_string(),

packages/rules/src/stellar/linting/stellar_sdk_rules.rs

@@ -114,18 +114,11 @@ impl SorobanLintRule for AddressValidationRule {
             // Check for functions with Address parameters that might need validation
             if line.contains("Address") && (line.contains("pub fn") || line.contains("fn ")) {
                 // Look ahead to see if there's validation
-                let next_lines = lines
-                    .iter()
-                    .skip(i)
-                    .take(15)
-                    .copied()
-                    .collect::<Vec<_>>()
-                    .join("\n");
-
-                if !next_lines.contains("require_auth")
-                    && !next_lines.contains("require_auth_for_args")
-                    && !next_lines.contains("try_from_xdr")
-                {
+                let next_lines = lines.iter().skip(i).take(15).copied().collect::<Vec<&str>>().join("\n");
+
+                if !next_lines.contains("require_auth") && 
+                   !next_lines.contains("require_auth_for_args") &&
+                   !next_lines.contains("try_from_xdr") {
                     violations.push(RuleViolation {
                         rule_name: self.id().to_string(),
                         description:

packages/rules/src/stellar/mod.rs

@@ -3,7 +3,9 @@
 //! This module provides Stellar and Soroban-specific analysis capabilities
 
 pub mod linting;
+pub mod unsafe_operations;
 pub mod upgradeability;
 
 pub use linting::*;
+pub use unsafe_operations::*;
 pub use upgradeability::*;