Bugfix colors segfault#966
Merged
VincentVanlaer merged 3 commits intor25.12.1_colors_updatedfrom Apr 14, 2026
Merged
Conversation
Debraheem
added
release-blocker
Collaborator
nialljmiller
left a comment
nialljmiller
left a comment
There was a problem hiding this comment.
This looks good to me. Thank you for fixing it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for r26.4.1, This pr introduces a minor tweak to colors that prevents the flux cube from being loaded into memory when use_colors = .false. . Given where we placed the return statement, we now need to explicitly load the flux cube In colors/test/test_colors.f90, since it's running without a namelist. I add a comment that we might want a separate inlist for this test case, but I left it as a comment for now.
Let me know if this is fine to merge, once it compiles. Hopefully it passes testing as well.